Make all Plugin classes sealed

emako · emako · commit c64885485d95 · 2026-01-08T01:06:37.000+08:00
Changed all Plugin classes and PluginManager to be sealed, preventing further inheritance. This improves code safety and clarifies the intended usage of these classes.
diff --git a/QuickLook.Plugin/QuickLook.Plugin.AppViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.AppViewer/Plugin.cs
@@ -24,7 +24,7 @@
 
 namespace QuickLook.Plugin.AppViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private static readonly string[] _extensions =
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.MoreMenu.cs b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.MoreMenu.cs
@@ -31,7 +31,7 @@
 
 namespace QuickLook.Plugin.ArchiveViewer;
 
-public partial class Plugin
+public sealed partial class Plugin
 {
     /// <summary>
     /// Command to extract archive contents to a directory. Executed asynchronously.
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs
@@ -27,7 +27,7 @@
 
 namespace QuickLook.Plugin.ArchiveViewer;
 
-public partial class Plugin : IViewer, IMoreMenu
+public sealed partial class Plugin : IViewer, IMoreMenu
 {
     private static readonly string[] _extensions =
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.CLSIDViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.CLSIDViewer/Plugin.cs
@@ -22,7 +22,7 @@
 
 namespace QuickLook.Plugin.CLSIDViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private CLSIDInfoPanel _ip;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs
@@ -22,7 +22,7 @@
 
 namespace QuickLook.Plugin.CsvViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private CsvViewerPanel _panel;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ELFViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.ELFViewer/Plugin.cs
@@ -27,7 +27,7 @@
 
 namespace QuickLook.Plugin.ELFViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     /// <summary>
     /// Magic number of ELF files
diff --git a/QuickLook.Plugin/QuickLook.Plugin.FontViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.FontViewer/Plugin.cs
@@ -24,7 +24,7 @@
 
 namespace QuickLook.Plugin.FontViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private WebfontPanel _panel;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.HelixViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HelixViewer/Plugin.cs
@@ -24,7 +24,7 @@
 
 namespace QuickLook.Plugin.HelixViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     /// <summary>
     /// <seealso cref="ImporterType"/>
diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.MoreMenu.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.MoreMenu.cs
@@ -25,7 +25,7 @@
 
 namespace QuickLook.Plugin.HtmlViewer;
 
-public partial class Plugin
+public sealed partial class Plugin
 {
     public IEnumerable<IMenuItem> GetMenuItems()
     {
diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs
@@ -26,7 +26,7 @@
 
 namespace QuickLook.Plugin.HtmlViewer;
 
-public partial class Plugin : IViewer, IMoreMenu
+public sealed partial class Plugin : IViewer, IMoreMenu
 {
     private static readonly string[] _extensions = [".mht", ".mhtml", ".htm", ".html"];
     private static readonly string[] _supportedProtocols = ["http", "https"];
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.MoreMenu.cs b/QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.MoreMenu.cs
@@ -25,7 +25,7 @@
 
 namespace QuickLook.Plugin.ImageViewer;
 
-public partial class Plugin
+public sealed partial class Plugin
 {
     public IEnumerable<IMenuItem> GetMenuItems()
     {
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.cs
@@ -29,7 +29,7 @@
 
 namespace QuickLook.Plugin.ImageViewer;
 
-public partial class Plugin : IViewer, IMoreMenu
+public sealed partial class Plugin : IViewer, IMoreMenu
 {
     private static readonly HashSet<string> WellKnownExtensions = new(
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs
@@ -26,7 +26,7 @@
 
 namespace QuickLook.Plugin.MailViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private WebpagePanel _panel;
     private string _tmpDir = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
diff --git a/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs
@@ -23,7 +23,7 @@
 
 namespace QuickLook.Plugin.MarkdownViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private MarkdownPanel _panel;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.MediaInfoViewer/Plugin.MoreMenu.cs b/QuickLook.Plugin/QuickLook.Plugin.MediaInfoViewer/Plugin.MoreMenu.cs
@@ -26,7 +26,7 @@
 
 namespace QuickLook.Plugin.MediaInfoViewer;
 
-public partial class Plugin
+public sealed partial class Plugin
 {
     public ICommand ShowWithMediaInfoCommand { get; }
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.MediaInfoViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.MediaInfoViewer/Plugin.cs
@@ -29,7 +29,7 @@
 
 namespace QuickLook.Plugin.MediaInfoViewer;
 
-public partial class Plugin : IViewer, IMoreMenuExtended
+public sealed partial class Plugin : IViewer, IMoreMenuExtended
 {
     private TextViewerPanel _tvp;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.OfficeViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.OfficeViewer/Plugin.cs
@@ -26,7 +26,7 @@
 
 namespace QuickLook.Plugin.OfficeViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private static readonly string[] Extensions =
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs
@@ -27,7 +27,7 @@
 
 namespace QuickLook.Plugin.PDFViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private ContextObject _context;
     private string _path;
diff --git a/QuickLook.Plugin/QuickLook.Plugin.PEViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.PEViewer/Plugin.cs
@@ -23,7 +23,7 @@
 
 namespace QuickLook.Plugin.PEViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private static readonly string[] _extensions =
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.PluginInstaller/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.PluginInstaller/Plugin.cs
@@ -23,7 +23,7 @@
 
 namespace QuickLook.Plugin.PluginInstaller;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     public int Priority => int.MaxValue;
 
diff --git a/QuickLook.Plugin/QuickLook.Plugin.TextViewer/Plugin.MoreMenu.cs b/QuickLook.Plugin/QuickLook.Plugin.TextViewer/Plugin.MoreMenu.cs
@@ -25,7 +25,7 @@
 
 namespace QuickLook.Plugin.TextViewer;
 
-public partial class Plugin
+public sealed partial class Plugin
 {
     public IEnumerable<IMenuItem> GetMenuItems()
     {
diff --git a/QuickLook.Plugin/QuickLook.Plugin.ThumbnailViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.ThumbnailViewer/Plugin.cs
@@ -27,7 +27,7 @@
 
 namespace QuickLook.Plugin.ThumbnailViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private static readonly HashSet<string> WellKnownExtensions = new(
     [
diff --git a/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/Plugin.cs
@@ -26,7 +26,7 @@
 
 namespace QuickLook.Plugin.VideoViewer;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private static MediaInfoLib _mediaInfo;
 
diff --git a/QuickLook/Plugin/InfoPanel/Plugin.cs b/QuickLook/Plugin/InfoPanel/Plugin.cs
@@ -20,7 +20,7 @@
 
 namespace QuickLook.Plugin.InfoPanel;
 
-public class Plugin : IViewer
+public sealed class Plugin : IViewer
 {
     private InfoPanel _ip;
 
diff --git a/QuickLook/PluginManager.cs b/QuickLook/PluginManager.cs
@@ -29,7 +29,7 @@
 
 namespace QuickLook;
 
-public class PluginManager
+public sealed class PluginManager
 {
     private static PluginManager _instance;
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`
`25`	`25`	`namespace QuickLook.Plugin.AppViewer;`
`26`	`26`
`27`		`-public class Plugin : IViewer`
	`27`	`+public sealed class Plugin : IViewer`
`28`	`28`	`{`
`29`	`29`	`private static readonly string[] _extensions =`
`30`	`30`	`[`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`
`32`	`32`	`namespace QuickLook.Plugin.ArchiveViewer;`
`33`	`33`
`34`		`-public partial class Plugin`
	`34`	`+public sealed partial class Plugin`
`35`	`35`	`{`
`36`	`36`	`/// <summary>`
`37`	`37`	`/// Command to extract archive contents to a directory. Executed asynchronously.`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`
`28`	`28`	`namespace QuickLook.Plugin.ArchiveViewer;`
`29`	`29`
`30`		`-public partial class Plugin : IViewer, IMoreMenu`
	`30`	`+public sealed partial class Plugin : IViewer, IMoreMenu`
`31`	`31`	`{`
`32`	`32`	`private static readonly string[] _extensions =`
`33`	`33`	`[`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`
`23`	`23`	`namespace QuickLook.Plugin.CLSIDViewer;`
`24`	`24`
`25`		`-public class Plugin : IViewer`
	`25`	`+public sealed class Plugin : IViewer`
`26`	`26`	`{`
`27`	`27`	`private CLSIDInfoPanel _ip;`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`
`26`	`26`	`namespace QuickLook.Plugin.HtmlViewer;`
`27`	`27`
`28`		`-public partial class Plugin`
	`28`	`+public sealed partial class Plugin`
`29`	`29`	`{`
`30`	`30`	`public IEnumerable<IMenuItem> GetMenuItems()`
`31`	`31`	`{`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`
`27`	`27`	`namespace QuickLook.Plugin.HtmlViewer;`
`28`	`28`
`29`		`-public partial class Plugin : IViewer, IMoreMenu`
	`29`	`+public sealed partial class Plugin : IViewer, IMoreMenu`
`30`	`30`	`{`
`31`	`31`	`private static readonly string[] _extensions = [".mht", ".mhtml", ".htm", ".html"];`
`32`	`32`	`private static readonly string[] _supportedProtocols = ["http", "https"];`