Improvement of LoadAndPlay method of the MidiPlayer.cs #1520
Closed
melanchall
started this conversation in
General
Replies: 2 comments
-
Good and feasible! |
Beta Was this translation helpful? Give feedback.
0 replies
-
Done e70c23a |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
I'm the author of the DryWetMIDI library. First of all, thank you for using it!
Just want to suggest a small improvement in the code of the
LoadAndPlay
method within theMidiPlayer.cs
file. You have such lines:But playback can run in two modes: blocking and non-blocking, as stated in the docs. So instead of the lines above just write:
Thank you again and happy new year! 🎉
Beta Was this translation helpful? Give feedback.
All reactions