Skip to content

Commit fa5671e

Browse files
Use new Docker image for previews (#1590)
We removed the remote refresh mechanism from the previews, so port 5001 is no longer relevant. We also can now use the Dockerhub image for both `./start` and IBM Code Engine PR previews, so we can be consistent and stop using the IBM Container Registry version. That simplifies our infra.
1 parent 03f533f commit fa5671e

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

Dockerfile

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,19 @@
1313
# This Dockerfile is used to preview the docs in pull requests via GitHub Actions.
1414
#
1515
# Keep it aligned with ./start. This Dockerfile is similar,
16-
# but it uses a private Docker image from IBM Cloud Registry rather
17-
# than a public image from Dockerhub. It also sets the CLI args
18-
# directly in the Dockerfile because the GitHub Action expects that.
16+
# but it sets the CLI args directly in the Dockerfile
17+
# because the GitHub Action expects that.
1918
#
20-
# To test it out locally, you will first need an IBM ID that has permissions to the quantum group. This is currently restricted to IBM maintainers. Then, set up IBM Cloud:
21-
#
22-
# 1. Install IBM CLI, https://cloud.ibm.com/docs/cli?topic=cli-getting-started
23-
# 2. ❯ ibmcloud plugin install cr
24-
# 3. ❯ ibmcloud login --sso
25-
# 4. ❯ ibmcloud cr region-set global
26-
# 5. ❯ ibmcloud cr login
27-
#
28-
# Once logged in to IBM Cloud:
19+
# To test it out locally:
2920
#
3021
# 1. ❯ docker build -t qiskit-docs-preview .
3122
# 2. ❯ docker run --rm -p 3000:3000 -t qiskit-docs-preview
3223
# 3. Open up http://localhost:3000
3324

34-
FROM icr.io/quantum-computing/iqp-channel-docs-dev:open-source
25+
FROM qiskit/documentation:latest
3526

3627
COPY docs/ /home/node/app/docs
3728
COPY translations/ /home/node/app/docs
3829
COPY public/ /home/node/app/packages/preview/public/
3930

40-
EXPOSE 3000 5001
31+
EXPOSE 3000

start

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ def main() -> None:
4949
f"{PWD}/public:/home/node/app/packages/preview/public",
5050
"-p",
5151
"3000:3000",
52-
"-p",
53-
"5001:5001",
5452
# Needed for ctrl-c to shut down the container.
5553
"--init",
5654
"qiskit/documentation",

0 commit comments

Comments
 (0)