Skip to content

Commit c7a7d53

Browse files
ElePTmtreinish
andauthored
Move collect_bicolor_runs() to rustworkx-core (#1186)
* Attempt with graph.node_weight * Progress until hitting error. * Return node ids instead of node weights. Code compiles!!! * Move collect_bicolor_runs.rs to rustworkx-core/src/dag_algo.rs * Add pyo3 wrapper for core collect_bicolor_runs, modify test, small fixes. * Fix DagHasCycle error to match previous type * Clean up unused parameters and functions, simplify error handling, add unit tests and reno. * Use PyResult, fix comments * Apply feedback from Matt's review, make tests make more sense. * Add suggestion from Matt's code review Co-authored-by: Matthew Treinish <[email protected]> * Remove stray print Co-authored-by: Matthew Treinish <[email protected]> * Change callbacks to take ids instead of weights, rename some variables in tests for clarity. * Fix test * Apply suggestions from code review Co-authored-by: Matthew Treinish <[email protected]> * Get rid of unused trait * Fix fmt --------- Co-authored-by: Matthew Treinish <[email protected]>
1 parent 2ad86a4 commit c7a7d53

File tree

5 files changed

+423
-107
lines changed

5 files changed

+423
-107
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
features:
3+
- |
4+
Added a new function ``collect_bicolor_runs`` to rustworkx-core's ``dag_algo`` module.
5+
Previously, the ``collect_bicolor_runs`` functionality for DAGs was only exposed
6+
via the Python interface. Now Rust users can take advantage of this functionality in ``rustworkx-core``.

0 commit comments

Comments
 (0)