Fix Clippy Lints for Rust 1.88 (#1472)

* Add ignore for files temporarily

* Address lint in test target as well

* Revert "Add ignore for files temporarily"

This reverts commit f8a8d03.

* Add first part of automated fixes

* Add second part of automated fixes

* Add third part of automated fixes

* Manual fix for missing line

* cargo fmt

* Undo the lint allows from merge

Author: IvanIsCoding

rustworkx-core/fuzz/fuzz_targets/test_fuzz_contraction.rs

@@ -1,5 +1,4 @@
 #![no_main]
-#![allow(clippy::uninlined_format_args)]
 
 use arbitrary::{Arbitrary, Unstructured};
 use libfuzzer_sys::fuzz_target;
@@ -66,7 +65,7 @@ fn fuzz_contract_nodes(input: ContractFuzzInput) {
             // Expected error — no-op
         }
         Err(err) => {
-            panic!("Unexpected error during node contraction: {:?}", err);
+            panic!("Unexpected error during node contraction: {err:?}");
         }
     }
 }

rustworkx-core/src/bipartite_coloring.rs

@@ -666,7 +666,7 @@ mod test_bipartite_coloring {
                 .map(|edge| *colors.get(&edge.id()).unwrap())
                 .collect();
             if node_colors.len() != node_degree {
-                panic!("Node {:?} does not have correct number of colors.", node);
+                panic!("Node {node:?} does not have correct number of colors.");
             }
         }
 
@@ -708,7 +708,7 @@ mod test_bipartite_coloring {
                 .map(|edge| *colors.get(&edge.id()).unwrap())
                 .collect();
             if node_colors.len() != node_degree {
-                panic!("Node {:?} does not have correct number of colors.", node);
+                panic!("Node {node:?} does not have correct number of colors.");
             }
         }
 

rustworkx-core/src/dag_algo.rs

@@ -59,7 +59,7 @@ impl<E: Error> Display for TopologicalSortError<E> {
                 write!(f, "At least one initial node is reachable from another")
             }
             TopologicalSortError::KeyError(ref e) => {
-                write!(f, "The key callback failed with: {:?}", e)
+                write!(f, "The key callback failed with: {e:?}")
             }
         }
     }
@@ -420,12 +420,11 @@ where
             self.first_iter = false;
             for node in &self.cur_layer {
                 if self.graph.to_index(*node) >= self.graph.node_bound() {
-                    panic!("Node {:#?} is not present in the graph.", node);
+                    panic!("Node {node:#?} is not present in the graph.");
                 }
                 if self.cycle_check.contains(node) {
                     return Some(Err(LayersError(format!(
-                        "An invalid first layer was provided: {:#?} appears more than once.",
-                        node
+                        "An invalid first layer was provided: {node:#?} appears more than once."
                     ))));
                 }
                 self.cycle_check.insert(*node);
@@ -436,7 +435,7 @@ where
         } else {
             for node in &self.cur_layer {
                 if self.graph.to_index(*node) >= self.graph.node_bound() {
-                    panic!("Node {:#?} is not present in the graph.", node);
+                    panic!("Node {node:#?} is not present in the graph.");
                 }
                 let children = self
                     .graph

rustworkx-core/src/err.rs

@@ -52,7 +52,7 @@ fn fmt_dag_would_cycle(f: &mut Formatter<'_>) -> std::fmt::Result {
 }
 
 fn fmt_merge_error<E: Error>(f: &mut Formatter<'_>, inner: &E) -> std::fmt::Result {
-    write!(f, "The merge callback failed with: {:?}", inner)
+    write!(f, "The merge callback failed with: {inner:?}")
 }
 
 /// Error returned by Layers function when an index is not part of the graph.

rustworkx-core/src/lib.rs

@@ -82,8 +82,6 @@
 //!
 //! <https://www.rustworkx.org/release_notes.html>
 
-#![allow(clippy::uninlined_format_args)]
-
 use std::convert::Infallible;
 
 /// A convenient type alias that by default assumes no error can happen.

rustworkx-core/src/shortest_path/dijkstra.rs

@@ -191,7 +191,7 @@ mod tests {
         g.add_edge(b, f, 15);
         g.add_edge(c, f, 11);
         g.add_edge(e, f, 6);
-        println!("{:?}", g);
+        println!("{g:?}");
         let scores: Result<DictMap<NodeIndex, usize>> =
             dijkstra(&g, a, None, |e| Ok(*e.weight()), None);
         let exp_scores: DictMap<NodeIndex, usize> =
@@ -220,7 +220,7 @@ mod tests {
         g.add_edge(b, f, 15);
         g.add_edge(c, f, 11);
         g.add_edge(e, f, 6);
-        println!("{:?}", g);
+        println!("{g:?}");
 
         let scores: Result<DictMap<NodeIndex, usize>> =
             dijkstra(&g, a, Some(c), |e| Ok(*e.weight()), None);

rustworkx-core/src/shortest_path/single_source_all_shortest_paths.rs

@@ -367,12 +367,7 @@ mod tests {
                 // Check no repeated nodes
                 let mut seen = HashSet::new();
                 for &n in path {
-                    assert!(
-                        seen.insert(n),
-                        "Path {:?} contains repeated node {:?}",
-                        path,
-                        n
-                    );
+                    assert!(seen.insert(n), "Path {path:?} contains repeated node {n:?}");
                 }
             }
         }

src/centrality.rs

@@ -748,8 +748,7 @@ pub fn graph_eigenvector_centrality(
                 .collect(),
         }),
         None => Err(FailedToConverge::new_err(format!(
-            "Function failed to converge on a solution in {} iterations",
-            max_iter
+            "Function failed to converge on a solution in {max_iter} iterations"
         ))),
     }
 }
@@ -836,8 +835,7 @@ pub fn digraph_eigenvector_centrality(
                 .collect(),
         }),
         None => Err(FailedToConverge::new_err(format!(
-            "Function failed to converge on a solution in {} iterations",
-            max_iter
+            "Function failed to converge on a solution in {max_iter} iterations"
         ))),
     }
 }
@@ -966,8 +964,7 @@ pub fn graph_katz_centrality(
                 .collect(),
         }),
         None => Err(FailedToConverge::new_err(format!(
-            "Function failed to converge on a solution in {} iterations",
-            max_iter
+            "Function failed to converge on a solution in {max_iter} iterations"
         ))),
     }
 }
@@ -1097,8 +1094,7 @@ pub fn digraph_katz_centrality(
                 .collect(),
         }),
         None => Err(FailedToConverge::new_err(format!(
-            "Function failed to converge on a solution in {} iterations",
-            max_iter
+            "Function failed to converge on a solution in {max_iter} iterations"
         ))),
     }
 }

src/dag_algo/mod.rs

@@ -301,8 +301,7 @@ pub fn layers(
     for layer_node in &first_layer {
         if !dag.graph.contains_node(NodeIndex::new(*layer_node)) {
             return Err(InvalidNode::new_err(format!(
-                "An index input in 'first_layer' {} is not a valid node index in the graph",
-                layer_node
+                "An index input in 'first_layer' {layer_node} is not a valid node index in the graph"
             )));
         }
     }

src/digraph.rs

@@ -895,8 +895,7 @@ impl PyDiGraph {
             Some(data) => data,
             None => {
                 return Err(PyIndexError::new_err(format!(
-                    "Provided edge index {} is not present in the graph",
-                    edge_index
+                    "Provided edge index {edge_index} is not present in the graph"
                 )));
             }
         };
@@ -917,8 +916,7 @@ impl PyDiGraph {
             Some(endpoints) => (endpoints.0.index(), endpoints.1.index()),
             None => {
                 return Err(PyIndexError::new_err(format!(
-                    "Provided edge index {} is not present in the graph",
-                    edge_index
+                    "Provided edge index {edge_index} is not present in the graph"
                 )));
             }
         };
@@ -2622,7 +2620,7 @@ impl PyDiGraph {
                 .as_bytes(),
             )?;
             match weight_callable(py, &weight_fn, edge.weight(), None as Option<String>)? {
-                Some(weight) => buf_writer.write_all(format!("{}{}\n", delim, weight).as_bytes()),
+                Some(weight) => buf_writer.write_all(format!("{delim}{weight}\n").as_bytes()),
                 None => buf_writer.write_all(b"\n"),
             }?;
         }
@@ -2875,8 +2873,7 @@ impl PyDiGraph {
         let node_index: NodeIndex = NodeIndex::new(node);
         if self.graph.node_weight(node_index).is_none() {
             return Err(PyIndexError::new_err(format!(
-                "Specified node {} is not in this graph",
-                node
+                "Specified node {node} is not in this graph"
             )));
         }
         // Copy nodes from other to self
@@ -2927,8 +2924,7 @@ impl PyDiGraph {
                     Some(new_index) => NodeIndex::new(*new_index),
                     None => {
                         return Err(PyIndexError::new_err(format!(
-                            "No mapped index {} found",
-                            old_index
+                            "No mapped index {old_index} found"
                         )))
                     }
                 },
@@ -2943,8 +2939,7 @@ impl PyDiGraph {
                     Some(new_index) => NodeIndex::new(*new_index),
                     None => {
                         return Err(PyIndexError::new_err(format!(
-                            "No mapped index {} found",
-                            old_index
+                            "No mapped index {old_index} found"
                         )))
                     }
                 },