Allow passing in arguments in squin.cirq.emit_circuit (#410)

Closes #407 

You can now do

```python
@squin.kernel
def main(n: int):
    squin.qubit.new(n)
    ...

circuit = squin.cirq.emit_circuit(main, args=(5,))
```

Unfortunately, you still can't have something like e.g.

```python
@squin.kernel
def main(q: ilist.IList[Qubit, Any]):
    ...

circuit = squin.cirq.emit_circuit(main, args=(squin.qubit.new(4),)
```

because you can't call `squin.qubit.new` outside of a squin kernel.
I'm not sure if there's anything we can do to make this happen, but in
this case you can resort to the workaround

```python
@squin.kernel
def wrapper():
    q = squin.qubit.new(4)
    main(q)

circuit = squin.cirq.emit_circuit(wrapper)
```

@jon-wurtz let me know if this works for you!

Author: david-pl

src/bloqade/squin/cirq/__init__.py

@@ -1,4 +1,5 @@
 from typing import Any, Sequence
+from warnings import warn
 
 import cirq
 from kirin import ir, types
@@ -157,6 +158,8 @@ def main():
 def emit_circuit(
     mt: ir.Method,
     qubits: Sequence[cirq.Qid] | None = None,
+    circuit_qubits: Sequence[cirq.Qid] | None = None,
+    args: tuple = (),
     ignore_returns: bool = False,
 ) -> cirq.Circuit:
     """Converts a squin.kernel method to a cirq.Circuit object.
@@ -165,12 +168,14 @@ def emit_circuit(
         mt (ir.Method): The kernel method from which to construct the circuit.
 
     Keyword Args:
-        qubits (Sequence[cirq.Qid] | None):
+        circuit_qubits (Sequence[cirq.Qid] | None):
             A list of qubits to use as the qubits in the circuit. Defaults to None.
             If this is None, then `cirq.LineQubit`s are inserted for every `squin.qubit.new`
             statement in the order they appear inside the kernel.
             **Note**: If a list of qubits is provided, make sure that there is a sufficient
             number of qubits for the resulting circuit.
+        args (tuple):
+            The arguments of the kernel function from which to emit a circuit.
         ignore_returns (bool):
             If `False`, emitting a circuit from a kernel that returns a value will error.
             Set it to `True` in order to ignore the return value(s). Defaults to `False`.
@@ -223,7 +228,7 @@ def main():
     # custom list of qubits on grid
     qubits = [cirq.GridQubit(i, i+1) for i in range(5)]
 
-    circuit = squin.cirq.emit_circuit(main, qubits=qubits)
+    circuit = squin.cirq.emit_circuit(main, circuit_qubits=qubits)
     print(circuit)
 
     ```
@@ -232,6 +237,12 @@ def main():
     and manipulate the qubits in other circuits directly written in cirq as well.
     """
 
+    if circuit_qubits is None and qubits is not None:
+        circuit_qubits = qubits
+        warn(
+            "The keyword argument `qubits` is deprecated. Use `circuit_qubits` instead."
+        )
+
     if (
         not ignore_returns
         and isinstance(mt.code, func.Function)
@@ -242,17 +253,24 @@ def main():
             " Set `ignore_returns = True` in order to simply ignore the return values and emit a circuit."
         )
 
+    if len(args) != len(mt.args):
+        raise ValueError(
+            f"The method from which you're trying to emit a circuit takes {len(mt.args)} as input, but you passed in {len(args)} via the `args` keyword!"
+        )
+
     emitter = EmitCirq(qubits=qubits)
 
     # Rewrite noise statements
     mt_ = mt.similar(mt.dialects)
     RewriteNoiseStmts(mt_.dialects)(mt_)
 
-    return emitter.run(mt_, args=())
+    return emitter.run(mt_, args=args)
 
 
 def dump_circuit(
     mt: ir.Method,
+    circuit_qubits: Sequence[cirq.Qid] | None = None,
+    args: tuple = (),
     qubits: Sequence[cirq.Qid] | None = None,
     ignore_returns: bool = False,
     **kwargs,
@@ -265,16 +283,24 @@ def dump_circuit(
         mt (ir.Method): The kernel method from which to construct the circuit.
 
     Keyword Args:
-        qubits (Sequence[cirq.Qid] | None):
+        circuit_qubits (Sequence[cirq.Qid] | None):
             A list of qubits to use as the qubits in the circuit. Defaults to None.
             If this is None, then `cirq.LineQubit`s are inserted for every `squin.qubit.new`
             statement in the order they appear inside the kernel.
             **Note**: If a list of qubits is provided, make sure that there is a sufficient
             number of qubits for the resulting circuit.
+        args (tuple):
+            The arguments of the kernel function from which to emit a circuit.
         ignore_returns (bool):
             If `False`, emitting a circuit from a kernel that returns a value will error.
             Set it to `True` in order to ignore the return value(s). Defaults to `False`.
 
     """
-    circuit = emit_circuit(mt, qubits=qubits, ignore_returns=ignore_returns)
+    circuit = emit_circuit(
+        mt,
+        circuit_qubits=circuit_qubits,
+        qubits=qubits,
+        args=args,
+        ignore_returns=ignore_returns,
+    )
     return cirq.to_json(circuit, **kwargs)

src/bloqade/squin/cirq/emit/emit_circuit.py

@@ -2,7 +2,7 @@
 from dataclasses import field, dataclass
 
 import cirq
-from kirin import ir
+from kirin import ir, interp
 from kirin.emit import EmitABC, EmitError, EmitFrame
 from kirin.interp import MethodTable, impl
 from kirin.dialects import func
@@ -45,6 +45,26 @@ def initialize_frame(
     def run_method(self, method: ir.Method, args: tuple[cirq.Circuit, ...]):
         return self.run_callable(method.code, args)
 
+    def run_callable_region(
+        self,
+        frame: EmitCirqFrame,
+        code: ir.Statement,
+        region: ir.Region,
+        args: tuple,
+    ):
+        if len(region.blocks) > 0:
+            block_args = list(region.blocks[0].args)
+            # NOTE: skip self arg
+            frame.set_values(block_args[1:], args)
+
+        results = self.eval_stmt(frame, code)
+        if isinstance(results, tuple):
+            if len(results) == 0:
+                return self.void
+            elif len(results) == 1:
+                return results[0]
+        raise interp.InterpreterError(f"Unexpected results {results}")
+
     def emit_block(self, frame: EmitCirqFrame, block: ir.Block) -> cirq.Circuit:
         for stmt in block.stmts:
             result = self.eval_stmt(frame, stmt)

test/cirq_utils/noise/test_noise_models.py

@@ -84,5 +84,5 @@ def test_simple_model(model: cirq.NoiseModel, qubits):
 
         assert pops[0] < 0.5001
         assert pops[3] < 0.5001
-        assert pops[1] > 0.0
-        assert pops[2] > 0.0
+        assert pops[1] >= 0.0
+        assert pops[2] >= 0.0

test/squin/cirq/test_cirq_to_squin.py

@@ -370,3 +370,39 @@ def manual():
         assert ket[1] == ket[2] == 0
         assert math.isclose(abs(ket[0]) ** 2, 0.5, abs_tol=1e-5)
         assert math.isclose(abs(ket[3]) ** 2, 0.5, abs_tol=1e-5)
+
+
+def test_kernel_with_args():
+
+    @squin.kernel
+    def main(n: int):
+        q = squin.qubit.new(n)
+        x = squin.op.x()
+        for i in range(n):
+            squin.qubit.apply(x, q[i])
+
+    main.print()
+
+    n_arg = 3
+    circuit = squin.cirq.emit_circuit(main, args=(n_arg,))
+    print(circuit)
+
+    q = cirq.LineQubit.range(n_arg)
+    expected_circuit = cirq.Circuit()
+    for i in range(n_arg):
+        expected_circuit.append(cirq.X(q[i]))
+
+    assert circuit == expected_circuit
+
+    @squin.kernel
+    def multi_arg(n: int, p: float):
+        q = squin.qubit.new(n)
+        h = squin.op.h()
+        squin.qubit.apply(h, q[0])
+
+        if p > 0:
+            squin.qubit.apply(h, q[1])
+
+    circuit = squin.cirq.emit_circuit(multi_arg, args=(3, 0.1))
+
+    print(circuit)

test/squin/test_sugar.py

@@ -87,7 +87,7 @@ def main():
     sim = StackMemorySimulator(min_qubits=2)
     ket = sim.state_vector(main)
 
-    assert math.isclose(abs(ket[0]) ** 2, 1, abs_tol=1e-7)
+    assert math.isclose(abs(ket[0]) ** 2, 1, abs_tol=1e-5)
     assert ket[1] == ket[2] == ket[3] == 0