Fixing more bugs

Author: weinbe58

src/bloqade/analysis/address/impls.py

@@ -166,7 +166,7 @@ def len_(
         self, interp_: AddressAnalysis, frame: ForwardFrame[Address], stmt: py.Len
     ):
         obj = frame.get(stmt.value)
-        values = self.get_values(obj)
+        _, values = self.get_values(obj)
 
         if values is None:
             return (Address.top(),)
@@ -188,8 +188,8 @@ def getitem(
         obj = frame.get(stmt.obj)
         index = frame.get(stmt.index)
 
-        values = self.get_values(obj)
-        if values is None:
+        typ, values = self.get_values(obj)
+        if typ is None:
             return (Address.top(),)
 
         match obj, index:
@@ -385,17 +385,17 @@ def ifelse(
                 then_results = interp_.run_ssacfg_region(
                     then_frame, stmt.then_body, (address_cond,)
                 )
-                # interp_.set_values(
-                #     frame, then_frame.entries.keys(), then_frame.entries.values()
-                # )
+                interp_.set_values(
+                    frame, then_frame.entries.keys(), then_frame.entries.values()
+                )
 
             with interp_.new_frame(stmt, has_parent_access=True) as else_frame:
                 else_results = interp_.run_ssacfg_region(
                     else_frame, stmt.else_body, (address_cond,)
                 )
-                # interp_.set_values(
-                #     frame, else_frame.entries.keys(), else_frame.entries.values()
-                # )
+                interp_.set_values(
+                    frame, else_frame.entries.keys(), else_frame.entries.values()
+                )
             # TODO: pick the non-return value
             if isinstance(then_results, interp.ReturnValue) and isinstance(
                 else_results, interp.ReturnValue

test/analysis/address/test_qubit_analysis.py

@@ -3,7 +3,7 @@
 from kirin.analysis import const
 from kirin.dialects import ilist
 
-from bloqade import squin
+from bloqade import qubit, squin
 from bloqade.analysis import address
 
 # test tuple and indexing
@@ -177,8 +177,38 @@ def main(n: int):
     )
 
 
-if __name__ == "__main__":
-    test_partial_tuple_add()
+def test_partial_tuple_add_failed():
+    @squin.kernel
+    def main(n: int):
+        return (0, 1) + [2, n]  # type: ignore
+
+    address_analysis = address.AddressAnalysis(main.dialects)
+    frame, result = address_analysis.run_analysis(main, no_raise=False)
+
+    assert result == address.Bottom()
+
+
+def test_partial_tuple_add_failed_2():
+    @squin.kernel
+    def main(n: tuple[int, ...]):
+        return (0, 1) + n
+
+    address_analysis = address.AddressAnalysis(main.dialects)
+    frame, result = address_analysis.run_analysis(main, no_raise=False)
+
+    assert result == address.Unknown()
+
+
+# need to pass in values from argument types
+@pytest.mark.xfail
+def test_partial_tuple_slice():
+    @squin.kernel
+    def main(q: qubit.Qubit):
+        return (0, q, 2, q)[1::2]
+
+    address_analysis = address.AddressAnalysis(main.dialects)
+    frame, result = address_analysis.run_analysis(main, no_raise=False)
+    assert result == address.UnknownReg()
 
 
 @pytest.mark.xfail