fixed missing registry + improper impl returns

Author: johnzl-777

squin_op_playground.py

@@ -3,21 +3,24 @@
 from kirin.dialects import py, func
 
 from bloqade import squin
-from bloqade.analysis import address
 from bloqade.squin.analysis import shape
 
 
 def as_int(value: int):
     return py.constant.Constant(value=value)
 
 
-squin_with_qasm_core = squin.groups.wired
+squin_with_qasm_core = squin.groups.wired.add(py)
 
 stmts: list[ir.Statement] = [
     (h0 := squin.op.stmts.H()),
     (h1 := squin.op.stmts.H()),
     (hh := squin.op.stmts.Kron(lhs=h1.result, rhs=h0.result)),
-    (func.Return(hh.result)),
+    (chh := squin.op.stmts.Control(hh.result, n_controls=1)),
+    (factor := as_int(1)),
+    # schh for some reason causes it to blow up
+    (schh := squin.op.stmts.Scale(chh.result, factor=factor.result)),
+    (func.Return(schh.result)),
 ]
 
 block = ir.Block(stmts)
@@ -40,19 +43,18 @@ def as_int(value: int):
 fold_pass = Fold(squin_with_qasm_core)
 fold_pass(constructed_method)
 
+""""
 address_frame, _ = address.AddressAnalysis(constructed_method.dialects).run_analysis(
     constructed_method, no_raise=False
 )
 
+
 constructed_method.print(analysis=address_frame.entries)
+"""
 
 shape_frame, _ = shape.ShapeAnalysis(constructed_method.dialects).run_analysis(
     constructed_method, no_raise=False
 )
 
-"""
-frame, _ = address.AddressAnalysis(constructed_method.dialects).run_analysis(
-    constructed_method, no_raise=False
-"""
 
 constructed_method.print(analysis=shape_frame.entries)

src/bloqade/squin/analysis/shape/__init__.py

@@ -1 +1,3 @@
+# Need this for impl registration to work properly!
+from . import impls as impls
 from .analysis import ShapeAnalysis as ShapeAnalysis

src/bloqade/squin/analysis/shape/analysis.py

@@ -26,8 +26,6 @@ def initialize(self):
 
     ## This gets called before the registry look up
     def eval_stmt(self, frame: ForwardFrame, stmt: ir.Statement):
-        # something fishy, registry pops up empty?
-        # This doesn't happen with the
         method = self.lookup_registry(frame, stmt)
         if method is not None:
             return method(self, frame, stmt)

src/bloqade/squin/analysis/shape/impls.py

@@ -61,9 +61,9 @@ def control(
     @interp.impl(op.stmts.Rot)
     def rot(self, interp: ShapeAnalysis, frame: interp.Frame, stmt: op.stmts.Rot):
         op_shape = frame.get(stmt.axis)
-        return op_shape
+        return (op_shape,)
 
     @interp.impl(op.stmts.Scale)
     def scale(self, interp: ShapeAnalysis, frame: interp.Frame, stmt: op.stmts.Scale):
         op_shape = frame.get(stmt.op)
-        return op_shape
+        return (op_shape,)