Update remaining code base to new kirin version #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-pl
added
the
breaking
weinbe58
approved these changes
Nov 5, 2025
Member
weinbe58
left a comment
weinbe58
left a comment
There was a problem hiding this comment.
Looked mostly at the code I have worked on, LGTM
kaihsin
requested changes
Nov 5, 2025
kaihsin
approved these changes
Nov 7, 2025
Contributor
|
remember to bump the deps version in toml |
Collaborator
Author
Since we're going via another branch, I'll merge this now and then make sure everything is updated and CI passes there. |
david-pl
merged commit 8f35f99
into
david/571-kirin-upgrade-branch
7 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is blocked by:
Other than that, we should be good. I'm still targeting the kirin upgrade branch to make review easier, but this once the above issues are resolved, this can actually go into
main.@weinbe58 please have a look at the address analysis, specifically at the
run_latticemethod. I had to change the signature a bit.