-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Bugs such as #293 would have been caught if the notebooks were executed regularly on release versions (similar to the nightly build we have for main branches). There are a few things we could do:
- Run examples using release versions once a week.
- Run examples as part of the CI for PRs using the current state in the PR. This might still fail when updating things to upcoming breaking changes.
- Run examples as part of the CI for PRs using the main branches of all submodules. This would cover the case of updating things to breaking changes, but I'm not sure this is really needed.
Note, that most of these could be alleviated if we just ran notebooks by default. However, that is blocked by printing issues of kirin.
Metadata
Metadata
Assignees
Labels
No labels