fix circular imports (#143)

this PR fixes circular imports by removing the re-export of
`rewrite.abc` and re-organize `attrs` and `types`, which is slightly
breaking. More specifically,

- `types` is moved into `attrs` as `kirin.ir.attrs.types`
- `py.data` dialect is removed, and `PyAttr` is now part of builtin
attributes because it is used within the IR module
- `py.base` is added to carry the minimum lowering transforms
- `julia.emit` now has a default `PyAttr` emit rule.
- `rewrite.abc` is no longer re-exported to avoid circular imports

the re-exports are still kinda messy, we will do a round of refactor of
that in future PRs.

Author: Roger-luo

src/kirin/decl/emit/init.py

@@ -29,7 +29,7 @@ class EmitInit(BaseModifier):
 
     def __init__(self, cls: type, **kwargs: Unpack[StatementOptions]) -> None:
         super().__init__(cls, **kwargs)
-        from kirin.dialects.py.data import PyAttr
+        from kirin.ir.attrs.py import PyAttr
 
         self._init_params: list[str] = []
         self._init_body: list[str] = []

src/kirin/decl/emit/property.py

@@ -111,7 +111,7 @@ def _emit_result_property(self, index: int, f: info.ResultField):
         return getter, setter
 
     def _emit_attribute_property(self, f: info.AttributeField):
-        from kirin.dialects.py.data import PyAttr
+        from kirin.ir.attrs.py import PyAttr
 
         storage = "properties" if f.property else "attributes"
         attr = f"{self._self_name}.{storage}['{f.name}']"

src/kirin/dialects/cf/stmts.py

@@ -1,7 +1,7 @@
 from kirin.ir import Block, SSAValue, Statement, IsTerminator
 from kirin.decl import info, statement
-from kirin.ir.types import Bool, String
 from kirin.print.printer import Printer
+from kirin.ir.attrs.types import Bool, String
 from kirin.dialects.cf.dialect import dialect
 
 

src/kirin/dialects/math/_gen.py

@@ -47,7 +47,7 @@ def builtin_math_functions():
     f.write("# This file is generated by gen.py\n")
     f.write("from kirin import ir\n")
     f.write("from kirin.decl import statement, info\n")
-    f.write("from kirin.ir.types import Float\n")
+    f.write("from kirin.ir.attrs.types import Float\n")
     f.write("from kirin.dialects.math.dialect import dialect\n")
     f.write("\n")
     for name, obj, sig in builtin_math_functions():

src/kirin/dialects/math/stmts.py

@@ -1,7 +1,7 @@
 # This file is generated by gen.py
 from kirin import ir
 from kirin.decl import info, statement
-from kirin.ir.types import Float
+from kirin.ir.attrs.types import Float
 from kirin.dialects.math.dialect import dialect
 
 

src/kirin/dialects/py/__init__.py

@@ -2,7 +2,7 @@
     cmp as cmp,
     len as len,
     attr as attr,
-    data as data,
+    base as base,
     binop as binop,
     ilist as ilist,
     range as range,
@@ -18,7 +18,6 @@
 )
 from .len import Len as Len
 from .attr import GetAttr as GetAttr
-from .data import PyAttr as PyAttr
 from .range import Range as Range
 from .slice import Slice as Slice
 from .append import Append as Append

src/kirin/dialects/py/assign.py

@@ -3,7 +3,6 @@
 from kirin import ir, interp, lowering, exceptions
 from kirin.decl import info, statement
 from kirin.print import Printer
-from kirin.dialects.py import data
 
 dialect = ir.Dialect("py.assign")
 
@@ -15,7 +14,7 @@ class Alias(ir.Statement):
     name = "alias"
     traits = frozenset({ir.Pure(), ir.FromPythonCall()})
     value: ir.SSAValue = info.argument(T)
-    target: data.PyAttr[str] = info.attribute(property=True)
+    target: ir.PyAttr[str] = info.attribute(property=True)
     result: ir.ResultValue = info.result(T)
 
     def print_impl(self, printer: Printer) -> None:
@@ -69,7 +68,7 @@ def lower_Assign(
                 targets=[ast.Name(lhs_name, ast.Store())], value=ast.Name(_, ast.Load())
             ):
                 stmt = Alias(
-                    value=results[0], target=data.PyAttr(lhs_name)
+                    value=results[0], target=ir.PyAttr(lhs_name)
                 )  # NOTE: this is guaranteed to be one result
                 stmt.result.name = lhs_name
                 current_frame.defs[lhs_name] = state.append_stmt(stmt).result

src/kirin/dialects/py/base.py

@@ -0,0 +1,34 @@
+"""Base dialect for Python.
+
+This dialect does not contain statements. It only contains
+lowering rules for `ast.Name` and `ast.Expr`.
+"""
+
+import ast
+
+from kirin import ir, lowering, exceptions
+
+dialect = ir.Dialect("py.base")
+
+
+@dialect.register
+class PythonLowering(lowering.FromPythonAST):
+
+    def lower_Name(
+        self, state: lowering.LoweringState, node: ast.Name
+    ) -> lowering.Result:
+        name = node.id
+        if isinstance(node.ctx, ast.Load):
+            value = state.current_frame.get(name)
+            if value is None:
+                raise exceptions.DialectLoweringError(f"{name} is not defined")
+            return lowering.Result(value)
+        elif isinstance(node.ctx, ast.Store):
+            raise exceptions.DialectLoweringError("unhandled store operation")
+        else:  # Del
+            raise exceptions.DialectLoweringError("unhandled del operation")
+
+    def lower_Expr(
+        self, state: lowering.LoweringState, node: ast.Expr
+    ) -> lowering.Result:
+        return state.visit(node.value)

src/kirin/dialects/py/constant.py

@@ -5,7 +5,6 @@
 from kirin.decl import info, statement
 from kirin.print import Printer
 from kirin.emit.julia import EmitJulia, EmitStrFrame
-from kirin.dialects.py.data import PyAttr
 
 dialect = ir.Dialect("py.constant")
 
@@ -20,9 +19,9 @@ class Constant(ir.Statement, Generic[T]):
     result: ir.ResultValue = info.result()
 
     # NOTE: we allow py.Constant take data.PyAttr too
-    def __init__(self, value: T | PyAttr[T]) -> None:
-        if not isinstance(value, PyAttr):
-            value = PyAttr(value)
+    def __init__(self, value: T | ir.PyAttr[T]) -> None:
+        if not isinstance(value, ir.PyAttr):
+            value = ir.PyAttr(value)
         super().__init__(
             properties={"value": value},
             result_types=(value.type,),
@@ -65,4 +64,4 @@ class JuliaTable(interp.MethodTable):
 
     @interp.impl(Constant)
     def emit_Constant(self, emit: EmitJulia, frame: EmitStrFrame, stmt: Constant):
-        return (emit.emit_attribute(PyAttr(stmt.value)),)
+        return (emit.emit_attribute(ir.PyAttr(stmt.value)),)