fix: verify + verify_type was not raising correctly (#383)

Thanks to @david-pl 's bug report (see test)

cc: @david-pl @kaihsin

Author: Roger-luo

src/kirin/decl/__init__.py

@@ -9,8 +9,8 @@
 from kirin.decl.emit.init import EmitInit
 from kirin.decl.emit.name import EmitName
 from kirin.decl.emit.repr import EmitRepr
+from kirin.decl.emit.check import EmitCheck
 from kirin.decl.emit.traits import EmitTraits
-from kirin.decl.emit.verify import EmitVerify
 from kirin.decl.scan_fields import ScanFields
 from kirin.decl.emit.dialect import EmitDialect
 from kirin.decl.emit.property import EmitProperty
@@ -26,7 +26,7 @@ class StatementDecl(
     EmitName,
     EmitRepr,
     EmitTraits,
-    EmitVerify,
+    EmitCheck,
     EmitCheckType,
 ):
     pass

src/kirin/decl/emit/verify.py src/kirin/decl/emit/check.pysrc/kirin/decl/emit/verify.py renamed to src/kirin/decl/emit/check.py

@@ -7,11 +7,11 @@
 from ._set_new_attribute import set_new_attribute
 
 
-class EmitVerify(BaseModifier):
+class EmitCheck(BaseModifier):
     _VERIFICATION_ERROR = "_kirin_ValidationError"
 
-    def emit_verify(self):
-        verify_locals: dict[str, Any] = {
+    def emit_check(self):
+        check_locals: dict[str, Any] = {
             self._VERIFICATION_ERROR: ValidationError,
         }
         body: list[str] = []
@@ -29,8 +29,8 @@ def emit_verify(self):
 
         if (traits := getattr(self.cls, "traits", None)) is not None:
             for trait in traits:
-                trait_obj = f"_kirin_verify_trait_{trait.__class__.__name__}"
-                verify_locals.update({trait_obj: trait})
+                trait_obj = f"_kirin_check_trait_{trait.__class__.__name__}"
+                check_locals.update({trait_obj: trait})
                 body.append(f"{trait_obj}.verify({self._self_name})")
 
         # NOTE: we still need to generate this because it is abstract
@@ -39,13 +39,13 @@ def emit_verify(self):
 
         set_new_attribute(
             self.cls,
-            "verify",
+            "check",
             create_fn(
-                name="_kirin_decl_verify",
+                name="_kirin_decl_check",
                 args=[self._self_name],
                 body=body,
                 globals=self.globals,
-                locals=verify_locals,
+                locals=check_locals,
                 return_type=None,
             ),
         )

src/kirin/decl/emit/check_type.py

@@ -8,7 +8,7 @@
 
 
 class EmitCheckType(BaseModifier):
-    _VERIFICATION_ERROR = "_kirin_IRValidationError"
+    _VERIFICATION_ERROR = "_kirin_ValidationError"
 
     def emit_check_type(self):
         check_type_locals: dict[str, Any] = {

src/kirin/exception.py

@@ -14,9 +14,10 @@
 
 from rich.console import Console
 
+from kirin.source import SourceInfo
+
 if TYPE_CHECKING:
     from kirin import interp
-    from kirin.source import SourceInfo
 
 KIRIN_INTERP_STATE = "__kirin_interp_state"
 KIRIN_PYTHON_STACKTRACE = os.environ.get("KIRIN_PYTHON_STACKTRACE", "0") == "1"

test/ir/test_verify.py

@@ -0,0 +1,49 @@
+import pytest
+
+from kirin import ir, lowering
+from kirin.decl import statement
+from kirin.prelude import basic_no_opt
+
+dialect = ir.Dialect("foo")
+
+
+@statement(dialect=dialect)
+class InvalidStmt(ir.Statement):
+    traits = frozenset({lowering.FromPythonCall()})
+
+    def check(self):
+        raise ValueError("Never triggers")
+
+
+@statement(dialect=dialect)
+class InvalidType(ir.Statement):
+    traits = frozenset({lowering.FromPythonCall()})
+
+    def check_type(self):
+        raise ValueError("Never triggers")
+
+
+@ir.dialect_group(basic_no_opt.add(dialect))
+def foo(self):
+    def run_pass(mt):
+        pass
+
+    return run_pass
+
+
+def test_invalid_stmt():
+    @foo
+    def test():
+        InvalidStmt()
+
+    with pytest.raises(Exception):
+        test.verify()
+
+
+def test_invalid_type():
+    @foo
+    def test():
+        InvalidType()
+
+    with pytest.raises(Exception):
+        test.verify_type()