Skip to content

Commit 8902fda

Browse files
committed
ci: Fix testing without LTO
The jobs matrix doesn't set any environment variables, so the without-LTO job just set `CFLAGS` in the matrix, which was never used for anything as intended.
1 parent 2f9edba commit 8902fda

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
pygobject-ver: '<3.52.0'
5757
- os: ubuntu-22.04
5858
python-version: '3.11'
59-
CFLAGS: "-fno-lto" # Ensure that disabling LTO works.
59+
lto: "--config-settings=setup-args=-Db_lto=false" # Ensure that disabling LTO works.
6060
extra-requirements: '-r requirements/testing/extra.txt'
6161
# https://github.com/matplotlib/matplotlib/issues/29844
6262
pygobject-ver: '<3.52.0'
@@ -318,7 +318,7 @@ jobs:
318318
fi
319319
320320
python -m pip install --no-deps --no-build-isolation --verbose \
321-
--config-settings=setup-args="-DrcParams-backend=Agg" \
321+
--config-settings=setup-args="-DrcParams-backend=Agg" ${{ matrix.lto }} \
322322
--editable .[dev]
323323
324324
if [[ "${{ runner.os }}" != 'macOS' ]]; then

0 commit comments

Comments
 (0)