Address approx 100 issues identified by mypy.stubtest

A couple more stubtest found errors

Fix typo in scale.pyi

Updates to type hints from looking at mypy over tutorials

Adjustments to type hints from inspecting examples

Reorg legend overloads

Author: ksunden

lib/matplotlib/_path.pyi

@@ -1,7 +1,7 @@
-from collections.abc import Sequence
+from typing import Sequence
 import numpy as np
 from .transforms import BboxBase
 
-def affine_transform(points: np.ndarray, matrix: np.ndarray) -> np.ndarray: ...
+def affine_transform(points: np.ndarray, trans: np.ndarray) -> np.ndarray: ...
 def count_bboxes_overlapping_bbox(a: BboxBase, bboxes: Sequence[BboxBase]) -> int: ...
 def update_path_extents(*args, **kwargs): ...

lib/matplotlib/animation.pyi

@@ -1,5 +1,5 @@
 import abc
-from collections.abc import Callable, Iterable, Generator
+from collections.abc import Callable, Collection, Iterable, Sequence, Generator
 import contextlib
 from pathlib import Path
 from matplotlib import cbook
@@ -207,15 +207,15 @@ class TimedAnimation(Animation):
     ) -> None: ...
 
 class ArtistAnimation(TimedAnimation):
-    def __init__(self, fig: Figure, artists: list[Artist], *args, **kwargs) -> None: ...
+    def __init__(self, fig: Figure, artists: Sequence[Collection[Artist]], *args, **kwargs) -> None: ...
 
 class FuncAnimation(TimedAnimation):
     save_count: int
     def __init__(
         self,
         fig: Figure,
         func: Callable[..., Iterable[Artist]],
-        frames: Iterable[Artist] | int | Generator[Artist, None, None] | None = ...,
+        frames: Iterable[Artist] | int | Callable[[], Generator] | None = ...,
         init_func: Callable[[], Iterable[Artist]] | None = ...,
         fargs: tuple[Any, ...] | None = ...,
         save_count: int | None = ...,

lib/matplotlib/artist.pyi

@@ -128,7 +128,7 @@ class Artist:
     def get_zorder(self) -> float: ...
     def set_zorder(self, level: float) -> None: ...
     @property
-    def sticky_edges(self) -> ArrayLike: ...
+    def sticky_edges(self) -> _XYPair: ...
     def update_from(self, other: Artist) -> None: ...
     def properties(self) -> dict[str, Any]: ...
     def update(self, props: dict[str, Any]) -> Any: ...
@@ -144,6 +144,11 @@ class Artist:
     def get_mouseover(self) -> bool: ...
     def set_mouseover(self, mouseover: bool) -> None: ...
 
+    @property
+    def mouseover(self) -> bool: ...
+    @mouseover.setter
+    def mouseover(self, mouseover: bool) -> None: ...
+
 class ArtistInspector:
     oorig: Artist | type[Artist]
     o: type[Artist]

lib/matplotlib/axes/_axes.pyi

@@ -57,11 +57,13 @@ class Axes(_AxesBase):
     @overload
     def legend(self) -> Legend: ...
     @overload
-    def legend(self, handles: Sequence[Artist], labels: Sequence[str]) -> Legend: ...
+    def legend(self, handles: Sequence[Artist], labels: Sequence[str], **kwargs) -> Legend: ...
     @overload
-    def legend(self, *, handles: Sequence[Artist]) -> Legend: ...
+    def legend(self, *, handles: Sequence[Artist], **kwargs) -> Legend: ...
     @overload
-    def legend(self, labels: Sequence[str]) -> Legend: ...
+    def legend(self, labels: Sequence[str], **kwargs) -> Legend: ...
+    @overload
+    def legend(self, **kwargs) -> Legend: ...
 
     def inset_axes(
         self,

lib/matplotlib/axes/_base.pyi

@@ -48,7 +48,10 @@ class _AxesBase(martist.Artist):
     yaxis: YAxis
     bbox: Bbox
     dataLim: Bbox
+    transAxes: Transform
     transScale: Transform
+    transLimits: Transform
+    transData: Transform
     ignore_existing_data_limits: bool
     axison: bool
     _projection_init: Any
@@ -199,6 +202,7 @@ class _AxesBase(martist.Artist):
     def axis(
         self,
         arg: tuple[float, float, float, float] | bool | str | None = ...,
+        /,
         *,
         emit: bool = ...
     ) -> tuple[float, float, float, float]: ...

lib/matplotlib/axis.pyi

@@ -54,7 +54,6 @@ class Tick(martist.Artist):
     def get_tick_padding(self) -> float: ...
     def get_children(self) -> list[martist.Artist]: ...
     stale: bool
-    def get_pad_pixels(self) -> float: ...
     def set_pad(self, val: float) -> None: ...
     def get_pad(self) -> None: ...
     def get_loc(self) -> float: ...
@@ -165,7 +164,6 @@ class Axis(martist.Artist):
     def get_inverted(self) -> bool: ...
     def set_inverted(self, inverted: bool) -> None: ...
     def set_default_intervals(self) -> None: ...
-    def get_ticklabel_extents(self, renderer: RendererBase) -> tuple[Bbox, Bbox]: ...
     def get_tightbbox(
         self, renderer: RendererBase | None = ..., *, for_layout_only: bool = ...
     ) -> Bbox | None: ...
@@ -248,7 +246,6 @@ class XAxis(Axis):
     label_position: Literal["bottom", "top"]
     stale: bool
     def set_label_position(self, position: Literal["bottom", "top"]) -> None: ...  # type: ignore[override]
-    def get_text_heights(self, renderer: RendererBase) -> tuple[float, float]: ...
     def set_ticks_position(
         self, position: Literal["top", "bottom", "both", "default", "none"]
     ) -> None: ...
@@ -265,7 +262,6 @@ class YAxis(Axis):
     stale: bool
     def set_label_position(self, position: Literal["left", "right"]) -> None: ...  # type: ignore[override]
     def set_offset_position(self, position: Literal["left", "right"]) -> None: ...
-    def get_text_widths(self, renderer: RendererBase) -> tuple[float, float]: ...
     def set_ticks_position(
         self, position: Literal["left", "right", "both", "default", "none"]
     ) -> None: ...

lib/matplotlib/backend_bases.pyi

@@ -329,7 +329,6 @@ class FigureCanvasBase:
     @classmethod
     def new_manager(cls, figure: Figure, num: int | str): ...
     def is_saving(self) -> bool: ...
-    def pick(self, mouseevent: MouseEvent) -> None: ...
     def blit(self, bbox: Bbox | None = ...) -> None: ...
     def inaxes(self, xy: tuple[float, float]) -> Axes | None: ...
     def grab_mouse(self, ax: Axes) -> None: ...
@@ -479,7 +478,7 @@ class ToolContainerBase:
 
 class _Backend:
     backend_version: str
-    FigureCanvas: type[FigureCanvasBase]
+    FigureCanvas: type[FigureCanvasBase] | None
     FigureManager: type[FigureManagerBase]
     mainloop: None | Callable[[], Any]
     @classmethod

lib/matplotlib/backend_tools.pyi

@@ -21,14 +21,15 @@ class Cursors(enum.IntEnum):
 cursors = Cursors
 
 class ToolBase:
-    default_keymap: list[str] | None
+    @property
+    def default_keymap(self) -> list[str] | None: ...
     description: str | None
     image: str | None
     def __init__(self, toolmanager: ToolManager, name: str) -> None: ...
     @property
     def name(self) -> str: ...
     @property
-    def toolmanger(self) -> ToolManager: ...
+    def toolmanager(self) -> ToolManager: ...
     @property
     def canvas(self) -> FigureCanvasBase | None: ...
     @property
@@ -37,7 +38,6 @@ class ToolBase:
     def figure(self, figure: Figure | None) -> None: ...
     def set_figure(self, figure: Figure | None) -> None: ...
     def trigger(self, sender: Any, event: ToolEvent, data: Any = ...) -> None: ...
-    def destroy(self) -> None: ...
 
 class ToolToggleBase(ToolBase):
     radio_group: str | None
@@ -119,4 +119,4 @@ default_toolbar_tools: list[list[str | list[str]]]
 def add_tools_to_manager(
     toolmanager: ToolManager, tools: dict[str, type[ToolBase]] = ...
 ) -> None: ...
-def add_tools_to_container(container: ToolContainerBase, tools: list[Any]) -> None: ...
+def add_tools_to_container(container: ToolContainerBase, tools: list[Any] = ...) -> None: ...

lib/matplotlib/cbook.pyi

@@ -59,7 +59,14 @@ def get_sample_data(
     fname: str | os.PathLike | io.FileIO,
     asfileobj: Literal[True] = ...,
     *,
-    np_load: bool = ...
+    np_load: Literal[True]
+) -> np.ndarray: ...
+@overload
+def get_sample_data(
+    fname: str | os.PathLike | io.FileIO,
+    asfileobj: Literal[True] = ...,
+    *,
+    np_load: Literal[False] = ...
 ) -> io.FileIO: ...
 @overload
 def get_sample_data(

lib/matplotlib/collections.pyi

@@ -136,8 +136,11 @@ class LineCollection(Collection):
     def get_segments(self) -> list[np.ndarray]: ...
     def set_color(self, c: ColorType | Sequence[ColorType]) -> None: ...
     def set_colors(self, c: ColorType | Sequence[ColorType]) -> None: ...
+    def set_gapcolor(self, gapcolor: ColorType | Sequence[ColorType] | None) -> None: ...
     def get_color(self) -> ColorType | Sequence[ColorType]: ...
     def get_colors(self) -> ColorType | Sequence[ColorType]: ...
+    def get_gapcolor(self) -> ColorType | Sequence[ColorType] | None: ...
+
 
 class EventCollection(LineCollection):
     def __init__(