[173-support-4x2-and-2x4-mode-in-hdawg] Removed "already deprecated" added function set_awg_module_index. Edited CHANGELOG.md accordingly.

Author: Henri Ervasti

CHANGELOG.md

@@ -10,8 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `run` method in `QMI_Context` class to accommodate for `threading.Thread` changes in Python 3.14.
 - `standard-xdrlib` from "dead batteries" as a dependency to fix issues coming from removal of `xdrlib` from standard library.
 - `grouping=2` input parameter in the `ZurichInstruments_Hdawg` to enable initialization directly in wanted grouping mode.
-- Addition of `set_awg_module_index` method to set the AWG module index number.
-- Addition of other new methods in Zurich Instruments HDAWG QMI driver. For example, now it is also possible to upload sequencer programs, command tables and waveforms to specific channel | core.
+- Addition of new methods in Zurich Instruments HDAWG QMI driver. For example, now it is also possible to upload sequencer programs, command tables and waveforms to specific AWG channel or AWG (core) index. Also setting DIO VALID index and polarity is now possible.
 - Python 3.14 CI pipelines.
 
 ### Changed

qmi/instruments/zurich_instruments/hdawg.py

@@ -716,30 +716,6 @@ def get_awg_module_index(self) -> int:
         """
         return self.awg_module.getInt("index")
 
-    @rpc_method
-    def set_awg_module_index(self, index: int):
-        """Set the AWG module index.
-
-        The currently set AWG module index, together with current grouping mode, defines which AWG cores will
-        be [en|dis]abled when 'set_awg_module_enabled' is called.
-
-        NOTE: It is possible to set any value regardless of the grouping mode, so it is up to the user to control
-              if the given index is valid.
-
-        Parameters:
-            index: AWG module index number in range 0..3.
-
-        Raises:
-            ValueError: If the given index value is invalid.
-        """
-        warnings.warn(
-            f"{self.get_awg_module_index.__name__} will be deprecated.", DeprecationWarning
-        )
-        if index not in range(self.NUM_AWGS):
-            raise ValueError(f"Index number {index} is invalid.")
-
-        self.awg_module.set("index", index)
-
     @rpc_method
     def get_awg_module_enabled(self) -> int:
         """Return the current enable status of the currently selected AWG module.

tests/instruments/zurich_instruments/test_hdawg.py

@@ -1489,26 +1489,6 @@ def test_get_awg_module_index(self):
         self._awg_module.awg.raw_module.getInt.assert_called_once_with("index")
         self.assertEqual(3, index)
 
-    def test_set_awg_module_index(self):
-        """Test setting AWG module index with good values."""
-        side_effect = [True, False] * 7  # group 0 = 4x, group 1 = 2x, group 2 = 1x
-        self._awg_module.finished.side_effect = side_effect + [False, True]  # For close
-        groupings = list(range(3))
-        for grouping in groupings:
-            self.hdawg._grouping = grouping
-            ok_indexes = list(range((2 - grouping) * 2))
-            ok_indexes = [0] if not ok_indexes else ok_indexes
-            for index in ok_indexes:
-                self.hdawg.set_awg_module_index(index)
-
-    def test_set_awg_module_index_exceptions(self):
-        """Test setting AWG module index with wrong values w.r.t. grouping."""
-        self._awg_module.finished.side_effect = [False, True]  # For close
-        nok_indexes = [-1, 4]
-        for index in nok_indexes:
-            with self.assertRaises(ValueError):
-                self.hdawg.set_awg_module_index(index)
-
     def test_get_awg_enabled(self):
         """Test getting AWG core enable state."""
         self.hdawg.get_awg_enabled(0)