Skip to content

Commit a207ea1

Browse files
committed
Rename Lua.Warning to WarningEmitted
1 parent c9de9db commit a207ea1

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

src/Laylua.Tests/Tests/Library/LuaTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ public void Warn_OnePieceMessage_TriggersWarningEvent()
301301
var collectedMessages = new List<string>();
302302

303303
Lua.OpenLibrary(LuaLibraries.Standard.Base);
304-
Lua.Warning += (_, e) =>
304+
Lua.WarningEmitted += (_, e) =>
305305
{
306306
collectedMessages.Add(e.Message.ToString());
307307
};
@@ -320,7 +320,7 @@ public void EmitWarning_OnePieceMessage_TriggersWarningEvent()
320320
const string Message = "This is a warning message.";
321321
var collectedMessages = new List<string>();
322322

323-
Lua.Warning += (_, e) =>
323+
Lua.WarningEmitted += (_, e) =>
324324
{
325325
collectedMessages.Add(e.Message.ToString());
326326
};
@@ -341,7 +341,7 @@ public void Warn_MultiPieceMessage_TriggersSingleWarningEvent()
341341
var collectedMessages = new List<string>();
342342

343343
Lua.OpenLibrary(LuaLibraries.Standard.Base);
344-
Lua.Warning += (_, e) =>
344+
Lua.WarningEmitted += (_, e) =>
345345
{
346346
collectedMessages.Add(e.Message.ToString());
347347
};
@@ -361,7 +361,7 @@ public void Warn_OffOnControlMessages_TogglesEmitsWarningsAccordingly()
361361
var collectedMessages = new List<string>();
362362

363363
Lua.OpenLibrary(LuaLibraries.Standard.Base);
364-
Lua.Warning += (_, e) =>
364+
Lua.WarningEmitted += (_, e) =>
365365
{
366366
collectedMessages.Add(e.Message.ToString());
367367
};

src/Laylua/Library/Lua.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using System.Diagnostics;
44
using System.Diagnostics.CodeAnalysis;
@@ -66,7 +66,7 @@ public object? this[string name]
6666
}
6767

6868
/// <summary>
69-
/// Gets or sets whether <see cref="Warning"/> should fire for emitted warnings. <br/>
69+
/// Gets or sets whether <see cref="WarningEmitted"/> should fire for emitted warnings. <br/>
7070
/// See <a href="https://www.lua.org/manual/5.4/manual.html#2.3">Error Handling (Lua manual)</a> and
7171
/// <a href="https://www.lua.org/manual/5.4/manual.html#pdf-warn"><c>warn (msg1, ···) (Lua Manual)</c></a> for more information about warnings.
7272
/// </summary>
@@ -84,7 +84,7 @@ public object? this[string name]
8484
/// <remarks>
8585
/// Subscribed event handlers must not throw any exceptions.
8686
/// </remarks>
87-
public event EventHandler<LuaWarningEventArgs> Warning
87+
public event EventHandler<LuaWarningEmittedEventArgs> WarningEmitted
8888
{
8989
add => _warningHandlers.Add(value);
9090
remove => _warningHandlers.Remove(value);
@@ -100,7 +100,7 @@ public event EventHandler<LuaWarningEventArgs> Warning
100100
private readonly List<LuaLibrary> _openLibraries;
101101

102102
private MemoryStream? _warningBuffer;
103-
private readonly List<EventHandler<LuaWarningEventArgs>> _warningHandlers;
103+
private readonly List<EventHandler<LuaWarningEmittedEventArgs>> _warningHandlers;
104104

105105
public Lua()
106106
: this(LuaMarshaler.Default)
@@ -128,7 +128,7 @@ private Lua(
128128
Marshaler = marshaler;
129129

130130
_openLibraries = new List<LuaLibrary>();
131-
_warningHandlers = new List<EventHandler<LuaWarningEventArgs>>();
131+
_warningHandlers = new List<EventHandler<LuaWarningEmittedEventArgs>>();
132132
MainThread = LuaThread.CreateMainThread(this);
133133
Globals = LuaTable.CreateGlobalsTable(this);
134134

@@ -192,7 +192,7 @@ private static void WarningHandler(void* ud, byte* msg, int tocont)
192192
{
193193
foreach (var handler in lua._warningHandlers)
194194
{
195-
handler.Invoke(lua, new LuaWarningEventArgs(message));
195+
handler.Invoke(lua, new LuaWarningEmittedEventArgs(message));
196196
}
197197
}
198198

@@ -234,7 +234,7 @@ public void EmitWarning(string? message)
234234
}
235235

236236
/// <summary>
237-
/// Emits a Lua warning that can fire <see cref="Warning"/>. <br/>
237+
/// Emits a Lua warning that can fire <see cref="WarningEmitted"/>. <br/>
238238
/// See <a href="https://www.lua.org/manual/5.4/manual.html#2.3">Error Handling (Lua manual)</a> and
239239
/// <a href="https://www.lua.org/manual/5.4/manual.html#pdf-warn"><c>warn (msg1, ···) (Lua Manual)</c></a> for more information about warnings.
240240
/// </summary>

src/Laylua/LuaWarningEventArgs.cs renamed to src/Laylua/Library/LuaWarningEmittedEventArgs.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@
33
namespace Laylua;
44

55
/// <summary>
6-
/// Represents event data for <see cref="Lua.Warning"/>.
6+
/// Represents event data for <see cref="Lua.WarningEmitted"/>.
77
/// </summary>
8-
public readonly struct LuaWarningEventArgs
8+
public readonly struct LuaWarningEmittedEventArgs
99
{
1010
/// <summary>
1111
/// Gets the warning message Lua emitted.
1212
/// </summary>
1313
public ReadOnlyMemory<char> Message { get; }
1414

15-
internal LuaWarningEventArgs(ReadOnlyMemory<char> message)
15+
internal LuaWarningEmittedEventArgs(ReadOnlyMemory<char> message)
1616
{
1717
Message = message;
1818
}

0 commit comments

Comments
 (0)