Bump golangci lint (#128)

amiros89 · web-flow · commit 0a541bb8c30c · 2025-03-24T17:30:52.000+02:00
* upgrade to golangci-lint 2.0.0

* bump action
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -27,7 +27,7 @@ jobs:
       - run: go mod download
       - run: go build -v .
       - name: Run linters
-        uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
+        uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
           version: latest
 
@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
         with:
-          go-version-file: 'go.mod'
+          go-version-file: "go.mod"
           cache: true
       # We need the latest version of Terraform for our documentation generation to use
       - uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd # v3.1.2
diff --git a/.golangci.bck.yml b/.golangci.bck.yml
@@ -0,0 +1,26 @@
+# Visit https://golangci-lint.run/ for usage documentation
+# and information on other useful linters
+issues:
+  max-same-issues: 0
+
+linters:
+  disable-all: true
+  enable:
+    - durationcheck
+    - errcheck
+    - copyloopvar
+    - forcetypeassert
+    - godot
+    - gofmt
+    - gosimple
+    - ineffassign
+    - makezero
+    - misspell
+    - nilerr
+    - predeclared
+    - staticcheck
+    - usetesting
+    - unconvert
+    - unparam
+    - unused
+    - govet
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,26 +1,42 @@
-# Visit https://golangci-lint.run/ for usage documentation
-# and information on other useful linters
-issues:
-  max-same-issues: 0
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
+    - copyloopvar
     - durationcheck
     - errcheck
-    - copyloopvar
     - forcetypeassert
     - godot
-    - gofmt
-    - gosimple
+    - govet
     - ineffassign
     - makezero
     - misspell
     - nilerr
     - predeclared
     - staticcheck
-    - usetesting
     - unconvert
     - unparam
     - unused
-    - govet
+    - usetesting
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+issues:
+  max-same-issues: 0
+formatters:
+  enable:
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
diff --git a/internal/provider/resources/space_email_notification_resource.go b/internal/provider/resources/space_email_notification_resource.go
@@ -231,7 +231,7 @@ func (r *TorqueSpaceEmailNotificationResource) Create(ctx context.Context, req r
 		return
 	}
 
-	data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))
+	data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))
 
 	tflog.Trace(ctx, "Resource Created Successful!")
 
diff --git a/internal/provider/resources/space_generic_webhook_notification_resource.go b/internal/provider/resources/space_generic_webhook_notification_resource.go
@@ -243,7 +243,7 @@ func (r *TorqueSpaceGenericWebhookNotificationResource) Create(ctx context.Conte
 		return
 	}
 
-	data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))
+	data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))
 
 	// Save data into Terraform state.
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
diff --git a/internal/provider/resources/space_slack_notification_resource.go b/internal/provider/resources/space_slack_notification_resource.go
@@ -238,7 +238,7 @@ func (r *TorqueSpaceSlackNotificationResource) Create(ctx context.Context, req r
 		return
 	}
 
-	data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))
+	data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))
 
 	tflog.Trace(ctx, "Resource Created Successful!")
 
diff --git a/internal/provider/resources/space_teams_notification_resource.go b/internal/provider/resources/space_teams_notification_resource.go
@@ -238,7 +238,7 @@ func (r *TorqueSpaceTeamsNotificationResource) Create(ctx context.Context, req r
 		return
 	}
 
-	data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))
+	data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))
 
 	tflog.Trace(ctx, "Resource Created Successful!")
 
diff --git a/internal/provider/resources/torque_azure_blob_object_content_input_source.go b/internal/provider/resources/torque_azure_blob_object_content_input_source.go
@@ -219,7 +219,7 @@ func (r *TorqueAzureBlobObjectContentInputSourceResource) Create(ctx context.Con
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
@@ -310,7 +310,7 @@ func (r *TorqueAzureBlobObjectContentInputSourceResource) Update(ctx context.Con
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
diff --git a/internal/provider/resources/torque_azure_blob_object_input_source.go b/internal/provider/resources/torque_azure_blob_object_input_source.go
@@ -193,7 +193,7 @@ func (r *TorqueAzureBlobObjectInputSourceResource) Create(ctx context.Context, r
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
@@ -280,7 +280,7 @@ func (r *TorqueAzureBlobObjectInputSourceResource) Update(ctx context.Context, r
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
diff --git a/internal/provider/resources/torque_deployment_engine_resource.go b/internal/provider/resources/torque_deployment_engine_resource.go
@@ -165,7 +165,7 @@ func (r *TorqueDeploymentEngineResource) Create(ctx context.Context, req resourc
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
@@ -230,7 +230,7 @@ func (r *TorqueDeploymentEngineResource) Update(ctx context.Context, req resourc
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
diff --git a/internal/provider/resources/torque_email_approval_channel.go b/internal/provider/resources/torque_email_approval_channel.go
@@ -110,7 +110,7 @@ func (r *TorqueEmailApprovalChannelResource) Create(ctx context.Context, req res
 
 	for _, approver := range data.Approvers.Elements() {
 		approvers = append(approvers, client.Approver{
-			UserEmail: strings.Replace(approver.String(), "\"", "", -1),
+			UserEmail: strings.ReplaceAll(approver.String(), "\"", ""),
 		})
 	}
 	details.Approvers = approvers
@@ -162,7 +162,7 @@ func (r *TorqueEmailApprovalChannelResource) Update(ctx context.Context, req res
 
 	for _, approver := range data.Approvers.Elements() {
 		approvers = append(approvers, client.Approver{
-			UserEmail: strings.Replace(approver.String(), "\"", "", -1),
+			UserEmail: strings.ReplaceAll(approver.String(), "\"", ""),
 		})
 	}
 	details.Approvers = approvers
diff --git a/internal/provider/resources/torque_environment.go b/internal/provider/resources/torque_environment.go
@@ -326,21 +326,21 @@ func (r *TorqueEnvironmentResource) Create(ctx context.Context, req resource.Cre
 
 	if !data.Inputs.IsNull() {
 		for key, value := range data.Inputs.Elements() {
-			inputs[key] = strings.Replace(value.String(), "\"", "", -1)
+			inputs[key] = strings.ReplaceAll(value.String(), "\"", "")
 		}
 	}
 	var tags = make(map[string]string)
 
 	if !data.Tags.IsNull() {
 		for key, value := range data.Tags.Elements() {
-			tags[key] = strings.Replace(value.String(), "\"", "", -1)
+			tags[key] = strings.ReplaceAll(value.String(), "\"", "")
 		}
 	}
 	var collaborators client.Collaborators
 	if data.Collaborators != nil {
 		var emails []string
 		for _, val := range data.Collaborators.CollaboratorsEmails.Elements() {
-			emails = append(emails, strings.Replace(val.String(), "\"", "", -1))
+			emails = append(emails, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		collaborators.AllSpaceMembers = data.Collaborators.AllSpaceMembers.ValueBool()
 		collaborators.Collaborators = emails
diff --git a/internal/provider/resources/torque_s3_object_content_input_source.go b/internal/provider/resources/torque_s3_object_content_input_source.go
@@ -208,7 +208,7 @@ func (r *TorqueS3ObjectContentInputSourceResource) Create(ctx context.Context, r
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
@@ -299,7 +299,7 @@ func (r *TorqueS3ObjectContentInputSourceResource) Update(ctx context.Context, r
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
diff --git a/internal/provider/resources/torque_s3_object_input_source.go b/internal/provider/resources/torque_s3_object_input_source.go
@@ -178,7 +178,7 @@ func (r *TorqueS3ObjectInputSourceResource) Create(ctx context.Context, req reso
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
@@ -256,7 +256,7 @@ func (r *TorqueS3ObjectInputSourceResource) Update(ctx context.Context, req reso
 	if !data.SpecificSpaces.IsNull() {
 		allowed_spaces.AllSpaces = false
 		for _, val := range data.SpecificSpaces.Elements() {
-			specificSpaces = append(specificSpaces, strings.Replace(val.String(), "\"", "", -1))
+			specificSpaces = append(specificSpaces, strings.ReplaceAll(val.String(), "\"", ""))
 		}
 		allowed_spaces.SpecificSpaces = specificSpaces
 	} else {
diff --git a/internal/provider/resources/torque_teams_approval_channel.go b/internal/provider/resources/torque_teams_approval_channel.go
@@ -117,7 +117,7 @@ func (r *TorqueTeamsApprovalChannelResource) Create(ctx context.Context, req res
 
 	for _, approver := range data.Approvers.Elements() {
 		approvers = append(approvers, client.Approver{
-			UserEmail: strings.Replace(approver.String(), "\"", "", -1),
+			UserEmail: strings.ReplaceAll(approver.String(), "\"", ""),
 		})
 	}
 	details.Approvers = approvers
@@ -171,7 +171,7 @@ func (r *TorqueTeamsApprovalChannelResource) Update(ctx context.Context, req res
 
 	for _, approver := range data.Approvers.Elements() {
 		approvers = append(approvers, client.Approver{
-			UserEmail: strings.Replace(approver.String(), "\"", "", -1),
+			UserEmail: strings.ReplaceAll(approver.String(), "\"", ""),
 		})
 	}
 	details.Approvers = approvers

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ func (r *TorqueSpaceEmailNotificationResource) Create(ctx context.Context, req r`
`231`	`231`	`return`
`232`	`232`	`}`
`233`	`233`
`234`		`- data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))`
	`234`	`+ data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))`
`235`	`235`
`236`	`236`	`tflog.Trace(ctx, "Resource Created Successful!")`
`237`	`237`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ func (r *TorqueSpaceGenericWebhookNotificationResource) Create(ctx context.Conte`
`243`	`243`	`return`
`244`	`244`	`}`
`245`	`245`
`246`		`- data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))`
	`246`	`+ data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))`
`247`	`247`
`248`	`248`	`// Save data into Terraform state.`
`249`	`249`	`resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ func (r *TorqueSpaceSlackNotificationResource) Create(ctx context.Context, req r`
`238`	`238`	`return`
`239`	`239`	`}`
`240`	`240`
`241`		`- data.NotificationId = basetypes.NewStringValue(strings.Replace(notification, "\"", "", -1))`
	`241`	`+ data.NotificationId = basetypes.NewStringValue(strings.ReplaceAll(notification, "\"", ""))`
`242`	`242`
`243`	`243`	`tflog.Trace(ctx, "Resource Created Successful!")`
`244`	`244`