Skip to content

Commit fafdde0

Browse files
authored
Update guidance for pytest-xdist in TSan docs (#306)
1 parent deb7ddc commit fafdde0

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

docs/thread_sanitizer.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,9 @@ Some authors of this guide have observed hangs running pytest with
209209
TSAN_OPTIONS.
210210

211211
The [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) plugin can also
212-
sometimes be problematic if a test runner happens to crash during
213-
execution. While `pytest-xdist` does have some support for detecting a crashed
214-
worker, it is not foolproof and the authors of this guide have observed hangs on
215-
CI due to pytest-xdist not properly handling a worker failing due to a TSan
216-
error.
212+
be useful, but be sure to [configure
213+
pytest](testing.md/#configure-timeouts-to-avoid-hanging-tests) to use
214+
faulthandler and exit on timeout to avoid having hangs in CI workers.
217215

218216
The `pytest-xdist` plugin also [makes it impossible to obtain stdout from
219217
a test runner](https://github.com/pytest-dev/pytest-xdist/issues/82), so there

0 commit comments

Comments
 (0)