Skip to content

Upgrade to Nx 15.9.1 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Upgrade to Nx 15.9.1 #816

wants to merge 39 commits into from

Conversation

@gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Nov 30, 2023 •
edited
Loading

This PR can somewhat be thought of as a re-opening of closed PR #723.

I wanted to go straight to the latest Nx version (17) but it was too much work. This will hopefully provide a stepping stone to future upgrades.

The process to create this PR looked something like:

git checkout develop
git pull
git checkout -b 15-9
nx migrate 15.9.1
git commit
npm install --force
git commit
# make some changes to package.json
git commit
npm install
git commit
# add .nx/cache to .gitignore
nx migrate --run-migrations --create-commits

Then I cherry picked a bunch of commits from #723.

@gabalafou
nx migrate 15.9.1
342590b
@gabalafou
npm install --force
d2392c2
@gabalafou
upgrade @testing-library/react, remove /react-hooks
51e36cd
@gabalafou
npm install
47caf82
@gabalafou
add .nx/cache to .gitignore
fd63f78
@gabalafou
chore: [nx migration] 15-7-0-split-configuration-into-project-json-files
7187882
@gabalafou
chore: [nx migration] 14-2-0-add-json-schema
8b209d0
@gabalafou
chore: [nx migration] 14-2-0-remove-default-collection
f149a67
@gabalafou
chore: [nx migration] 14.3.4-create-target-defaults
b0625eb
@gabalafou
chore: [nx migration] 15.0.0-migrate-to-inputs
9a985a9
@gabalafou
chore: [nx migration] 15.0.0-prefix-outputs
3d37f9e
@gabalafou
chore: [nx migration] add-default-development-configurations-14.0.0
d3f443f
@gabalafou
chore: [nx migration] add-dev-output-path
98d9b5f
@gabalafou
chore: [nx migration] add-gitignore-entry
52b547b
@gabalafou
chore: [nx migration] update-dev-output-path
fbbde1c
@gabalafou
chore: [nx migration] update-jest-config-extensions
c4e333f
@gabalafou
chore: [nx migration] update-to-export-default
f985787
@gabalafou
chore: [nx migration] add-jest-inputs
0b0de48
@gabalafou
chore: [nx migration] update-configs-jest-29
c82d2ff
@gabalafou
chore: [nx migration] add-babel-inputs
89ab7fa
@gabalafou
chore: [nx migration] update-babel-preset
8a7f1ee
@gabalafou
chore: [nx migration] 13-9-0-replace-tao-with-nx
233288d
@gabalafou
chore: [nx migration] 13-10-0-update-tasks-runner
4dbf637
@gabalafou
chore: [nx migration] update-react-18-13.10.0
a3233be
@gabalafou
chore: [nx migration] update-babel-jest-transform-option
4884ec1
@gabalafou
chore: [nx migration] add-eslint-inputs
1d0414d
@gabalafou
package-lock.json was updated
9c09f5d
@gabalafou
jest presets
8023d03
@gabalafou
next code mode no more Link > a
7cb6694
@gabalafou
remove experimenal image flag and import
dd52161
@vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 4:07pm

@gabalafou gabalafou requested a review from bskinn November 30, 2023 02:39
@gabalafou
Copy link
Contributor Author

gabalafou commented Nov 30, 2023

Note the following commands run without errors locally:

nx serve labs
nx lint labs
nx test labs

The same commands except test also worked for consulting. nx test consulting produces an error about fetch not being available globally. The error is thrown by the Apollo client constructor. It's puzzling to me because fetch has been a global in Node.js since v18.

Nonetheless, I get the same error on develop when I run nx test consulting so it shouldn't hold back this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bskinn bskinn Awaiting requested review from bskinn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabalafou