Dotnet 9 (#19)

Author: Martin-Molinero

.github/workflows/gh-actions.yml

@@ -6,17 +6,18 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
-    env:
-        QC_BITFINEX_API_SECRET: ${{ secrets.QC_BITFINEX_API_SECRET }}
-        QC_BITFINEX_API_KEY: ${{ secrets.QC_BITFINEX_API_KEY }}
-        QC_JOB_USER_ID: ${{ secrets.JOB_USER_ID }}
-        QC_API_ACCESS_TOKEN: ${{ secrets.API_ACCESS_TOKEN }}
-        QC_JOB_ORGANIZATION_ID: ${{ secrets.JOB_ORGANIZATION_ID }}
-    container:
-        image: quantconnect/lean:foundation
+    runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Liberate disk space
+        uses: jlumbroso/free-disk-space@main
+        with:
+          tool-cache: true
+          large-packages: false
+          docker-images: false
+          swap-storage: false
 
       - name: Checkout Lean Same Branch
         id: lean-same-branch
@@ -37,8 +38,13 @@ jobs:
       - name: Move Lean
         run: mv Lean ../Lean
 
-      - name: Build
-        run: dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.BitfinexBrokerage.sln
-
-      - name: Run Tests
-        run: dotnet test ./QuantConnect.BitfinexBrokerage.Tests/bin/Release/QuantConnect.BitfinexBrokerage.Tests.dll
+      - uses: addnab/docker-run-action@v3
+        with:
+          image: quantconnect/lean:foundation
+          options: --workdir /__w/Lean.Brokerages.Bitfinex/Lean.Brokerages.Bitfinex -v /home/runner/work:/__w -e QC_BITFINEX_API_SECRET=${{ secrets.QC_BITFINEX_API_SECRET }} -e QC_BITFINEX_API_KEY=${{ secrets.QC_BITFINEX_API_KEY }} -e QC_JOB_USER_ID=${{ secrets.JOB_USER_ID }} -e QC_API_ACCESS_TOKEN=${{ secrets.API_ACCESS_TOKEN }} -e QC_JOB_ORGANIZATION_ID=${{ secrets.JOB_ORGANIZATION_ID }}
+          shell: bash
+          run: |
+            # Build
+            dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.BitfinexBrokerage.sln && \
+            # Run Tests
+            dotnet test ./QuantConnect.BitfinexBrokerage.Tests/bin/Release/QuantConnect.BitfinexBrokerage.Tests.dll

QuantConnect.BitfinexBrokerage.Tests/BitfinexBrokerageTests.cs

@@ -39,7 +39,7 @@ protected override IBrokerage CreateBrokerage(IOrderProvider orderProvider, ISec
         {
             var securities = new SecurityManager(new TimeKeeper(DateTime.UtcNow, TimeZones.NewYork))
             {
-                {Symbol, CreateSecurity(Symbol)}
+                {Symbol, SecurityProvider.GetSecurity(Symbol)}
             };
 
             var transactions = new SecurityTransactionManager(null, securities);

QuantConnect.BitfinexBrokerage.Tests/QuantConnect.BitfinexBrokerage.Tests.csproj

@@ -3,7 +3,7 @@
     <PropertyGroup>
         <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
         <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
 
         <IsPackable>false</IsPackable>
         <Copyright>Copyright ©  2021</Copyright>
@@ -18,10 +18,9 @@
 
     <ItemGroup>
         <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
-        <PackageReference Include="NUnit" Version="3.13.3" />
-        <PackageReference Include="NUnit3TestAdapter" Version="4.2.1">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        <PackageReference Include="NUnit" Version="4.2.2" />
+        <PackageReference Include="NUnit3TestAdapter" Version="4.6.0">
+                <PrivateAssets>all</PrivateAssets>
         </PackageReference>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
     </ItemGroup>
@@ -31,7 +30,9 @@
       <ProjectReference Include="..\QuantConnect.BitfinexBrokerage.ToolBox\QuantConnect.BitfinexBrokerage.ToolBox.csproj" />
       <ProjectReference Include="..\QuantConnect.BitfinexBrokerage\QuantConnect.BitfinexBrokerage.csproj" />
     </ItemGroup>
-
+    <ItemGroup>
+        <Using Include="NUnit.Framework.Legacy.ClassicAssert" Alias="Assert" />
+    </ItemGroup>
     <ItemGroup>
         <None Remove="config.json" />
         <Content Include="config.json">

QuantConnect.BitfinexBrokerage.ToolBox/QuantConnect.BitfinexBrokerage.ToolBox.csproj

@@ -4,7 +4,7 @@
         <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
         <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
         <Copyright>Copyright ©  2021</Copyright>
         <OutputPath>bin\$(Configuration)\</OutputPath>
         <Product>QuantConnect.BitfinexBrokerage.ToolBox</Product>

QuantConnect.BitfinexBrokerage/QuantConnect.BitfinexBrokerage.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Product>QuantConnect.BitfinexBrokerage</Product>
     <AssemblyName>QuantConnect.BitfinexBrokerage</AssemblyName>
     <RootNamespace>QuantConnect.BitfinexBrokerage</RootNamespace>