Resolve review comments

Author: JosueNina

Tests/Common/Securities/MarketHoursDatabaseTests.cs

@@ -14,6 +14,7 @@
 */
 
 using System;
+using System.Collections.Generic;
 using System.Globalization;
 using System.IO;
 using System.Linq;
@@ -438,56 +439,74 @@ public void CustomEntriesAreNotLostWhenReset(string ticker, SecurityType securit
         [Test]
         public void VerifyMarketHoursDataIntegrityForAllSymbols()
         {
+            // Register the "nfo" market
+            Market.Add("nfo", 100);
+
             // Load the market hours database
             var marketHoursDatabase = MarketHoursDatabase.FromDataFolder();
 
+            // Test all specific entries
+            foreach (var entry in marketHoursDatabase.ExchangeHoursListing)
+            {
+                var securityType = entry.Key.SecurityType;
+                var ticker = entry.Key.Symbol;
+                Assert.IsFalse(string.IsNullOrEmpty(ticker), $"Ticker is null or empty");
+                var market = entry.Key.Market;
+
+                // Create symbol
+                Symbol symbol;
+                if (ticker.Contains("[*]") || ticker == "*")
+                {
+                    symbol = Symbol.Create("TEST_SYMBOL", securityType, market);
+                }
+                else
+                {
+                    symbol = Symbol.Create(ticker, securityType, market);
+                }
+
+                TestMarketHoursForSymbol(marketHoursDatabase, market, symbol, securityType);
+            }
+        }
+
+        private static void TestMarketHoursForSymbol(MarketHoursDatabase marketHoursDatabase, string market, Symbol symbol, SecurityType securityType)
+        {
             // Define date range (1998-01-01 to today, checking daily)
             var startDate = new DateTime(1998, 1, 1);
             var endDate = DateTime.Now;
 
-            // Iterate through all entries in the database
-            foreach (var entry in marketHoursDatabase.ExchangeHoursListing)
+            var exchangeHours = marketHoursDatabase.GetExchangeHours(market, symbol, securityType);
+
+            // Check every day
+            for (var date = startDate; date <= endDate; date = date.AddDays(1))
             {
-                var market = entry.Key.Market;
-                var symbol = entry.Key.Symbol;
-                var securityType = entry.Key.SecurityType;
+                // Get market hours for this date
+                var marketHours = exchangeHours.GetMarketHours(date);
+
+                // Ensure market hours exist for the date
+                Assert.IsNotNull(exchangeHours, "Exchange hours should not be null.");
 
-                // Skip entries with null symbol
-                if (string.IsNullOrEmpty(symbol))
+                var segments = marketHours.Segments;
+                for (int i = 1; i < segments.Count; i++)
                 {
-                    continue;
+                    // Ensure segments do not overlap
+                    Assert.LessOrEqual(segments[i - 1].End, segments[i].Start,
+                        $"Segments overlap for {symbol} on {date:yyyy-MM-dd} between {segments[i - 1]} and {segments[i]}");
+                }
+
+                bool hasEarlyClose = exchangeHours.EarlyCloses.TryGetValue(date, out var earlyCloseTime);
+                bool hasLateOpen = exchangeHours.LateOpens.TryGetValue(date, out var lateOpenTime);
+                if (hasEarlyClose && hasLateOpen && segments.Count > 0)
+                {
+                    // Ensure LateOpen time is not after market close, but only when there is an EarlyClose
+                    Assert.LessOrEqual(lateOpenTime, segments[^1].End,
+                        $"Late open time {lateOpenTime} is after market close {segments[^1].End} for {symbol} on {date:yyyy-MM-dd}");
                 }
 
-                // Check every day
-                for (var date = startDate; date <= endDate; date = date.AddDays(1))
+                if (exchangeHours.Holidays.Contains(date))
                 {
-                    // Get market hours for this date
-                    var exchangeHours = marketHoursDatabase.GetExchangeHours(market, symbol, securityType);
-                    var marketHours = exchangeHours.GetMarketHours(date);
-
-                    // Ensure market hours exist for the date
-                    Assert.IsNotNull(marketHours, $"Market hours should not be null for {symbol} on {date:yyyy-MM-dd}.");
-
-                    var segments = marketHours.Segments;
-                    for (int i = 1; i < segments.Count; i++)
-                    {
-                        // Ensure segments do not overlap
-                        Assert.IsTrue(segments[i].Start >= segments[i - 1].End);
-                    }
-
-                    bool hasEarlyClose = exchangeHours.EarlyCloses.TryGetValue(date, out var earlyCloseTime);
-                    bool hasLateOpen = exchangeHours.LateOpens.TryGetValue(date, out var lateOpenTime);
-                    if (hasEarlyClose && hasLateOpen && segments.Count > 0)
-                    {
-                        // Ensure LateOpen time is not after market close, but only when there is an EarlyClose
-                        Assert.IsTrue(lateOpenTime <= segments[^1].End);
-                    }
-
-                    if (exchangeHours.Holidays.Contains(date))
-                    {
-                        // Ensure market is fully closed on holidays
-                        Assert.IsTrue(marketHours.IsClosedAllDay);
-                    }
+                    // Ensure market is fully closed on holidays
+                    Assert.IsTrue(marketHours.IsClosedAllDay,
+                        $"Market should be fully closed on holiday {date:yyyy-MM-dd} for {symbol}");
                 }
             }
         }