Address peer review

Author: jhonabreul

src/embed_tests/TestPropertyAccess.cs

@@ -1091,7 +1091,7 @@ def GetValue(self, fixture):
                 var result = model.GetValue(fixture) as PyObject;
                 Assert.IsFalse(result.IsNone());
                 Assert.AreEqual(result.PyType, Exceptions.AttributeError);
-                Assert.AreEqual("'Python.EmbeddingTest.TestPropertyAccess+DynamicFixture' object has no attribute 'AnotherProperty'",
+                Assert.AreEqual("'DynamicFixture' object has no attribute 'AnotherProperty'",
                     result.ToString());
             }
         }

src/runtime/ClassManager.cs

@@ -184,11 +184,6 @@ internal static ClassBase CreateClass(Type type)
                 impl = new KeyValuePairEnumerableObject(type);
             }
 
-            else if (typeof(IDynamicMetaObjectProvider).IsAssignableFrom(type))
-            {
-                impl = new DynamicClassObject(type);
-            }
-
             else if (type.IsInterface)
             {
                 impl = new InterfaceObject(type);
@@ -207,6 +202,11 @@ internal static ClassBase CreateClass(Type type)
                 impl = new ClassDerivedObject(type);
             }
 
+            else if (typeof(IDynamicMetaObjectProvider).IsAssignableFrom(type))
+            {
+                impl = new DynamicClassObject(type);
+            }
+
             else
             {
                 impl = new ClassObject(type);

src/runtime/Types/DynamicClassObject.cs

@@ -67,33 +67,24 @@ public static NewReference tp_getattro(BorrowedReference ob, BorrowedReference k
         {
             var result = Runtime.PyObject_GenericGetAttr(ob, key);
 
-            // Property not found, but it can still be a dynamic one if the object is an IDynamicMetaObjectProvider
-            if (result.IsNull())
+            // If AttributeError was raised, we try to get the attribute from the managed object dynamic properties.
+            if (Exceptions.ExceptionMatches(Exceptions.AttributeError))
             {
                 var clrObj = (CLRObject)GetManagedObject(ob)!;
-                if (clrObj?.inst is IDynamicMetaObjectProvider)
-                {
-
-                    // The call to Runtime.PyObject_GenericGetAttr above ended up with an AttributeError
-                    // for dynamic properties since they are not found in the C# object definition.
-                    if (Exceptions.ExceptionMatches(Exceptions.AttributeError))
-                    {
-                        Exceptions.Clear();
-                    }
 
-                    var name = Runtime.GetManagedString(key);
-                    var clrObjectType = clrObj.inst.GetType();
-                    var callSite = GetAttrCallSite(name, clrObjectType);
+                var name = Runtime.GetManagedString(key);
+                var clrObjectType = clrObj.inst.GetType();
+                var callSite = GetAttrCallSite(name, clrObjectType);
 
-                    try
-                    {
-                        var res = callSite.Target(callSite, clrObj.inst);
-                        return Converter.ToPython(res);
-                    }
-                    catch (RuntimeBinder.RuntimeBinderException)
-                    {
-                        Exceptions.SetError(Exceptions.AttributeError, $"'{clrObjectType}' object has no attribute '{name}'");
-                    }
+                try
+                {
+                    var res = callSite.Target(callSite, clrObj.inst);
+                    Exceptions.Clear();
+                    result = Converter.ToPython(res);
+                }
+                catch (RuntimeBinder.RuntimeBinderException)
+                {
+                    // Do nothing, AttributeError was already raised in Python side and it was not cleared.
                 }
             }