-
-
Notifications
You must be signed in to change notification settings - Fork 24
⬆️ Upgrade build software and dependencies #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Upgrade anaconda to 2025.12 - Upgrade quantecon-book-theme to 0.15.1 - Add jupyter-book version constraint (<2.0) - Configure Dependabot for conda ecosystem with jupyter-book restriction - Add nb_merge_streams and path_to_docs to _config.yml - Temporarily disable build cache for full execution check
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add kaleido to environment.yml for reliable image export - Update all fig.to_image() calls to use engine='kaleido' - Fixes execution errors in BCG_complete_mkts, BCG_incomplete_mkts, and knowing_forecasts_of_others - Kaleido is the modern replacement for orca and works reliably in CI environments
- Update objf_prime to return 1D gradient array instead of 2D - Fixes 'Input array gradx must be 1D' error in amss2 and amss3 - Resolves compatibility issue with scipy.optimize.fmin_slsqp in Python 3.13
|
Fixed the amss2 and amss3 build errors. The issue was a scipy compatibility problem with Python 3.13. The Changes:
Commit: eb0d904 |
Python version should be constrained by the anaconda distribution version specified in environment.yml, not updated independently by dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades build software and dependencies to align with lecture-python-intro, updating the build environment to use newer versions of critical packages and adjusting configuration to support these updates.
Key Changes:
- Upgraded anaconda to 2025.12 and quantecon-book-theme to 0.15.1
- Added kaleido dependency and updated plotting calls to use the kaleido engine
- Fixed a bug in recursive_allocation.py where gradient computation was incorrectly implemented as a Jacobian matrix
- Added conda ecosystem support to dependabot with appropriate version constraints
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| environment.yml | Upgrades anaconda and quantecon-book-theme versions, adds kaleido dependency, and constrains jupyter-book to <2.0 |
| .github/dependabot.yml | Adds conda ecosystem configuration with weekly updates and ignore rules for jupyter-book and python |
| .github/workflows/ci.yml | Temporarily disables build cache to ensure full execution checks |
| lectures/_config.yml | Adds nb_merge_streams and path_to_docs configuration options |
| lectures/knowing_forecasts_of_others.md | Updates plotly to_image() call to explicitly use kaleido engine |
| lectures/BCG_incomplete_mkts.md | Updates multiple plotly to_image() calls to explicitly use kaleido engine |
| lectures/BCG_complete_mkts.md | Updates plotly to_image() call to explicitly use kaleido engine |
| lectures/_static/lecture_specific/amss2/recursive_allocation.py | Fixes bug where objf_prime incorrectly computed a Jacobian matrix instead of a gradient vector |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
@HumphreyYang tried to fix a few issues with the execution due to upgrades in software. If you have any time to take a look at the suggestions and updates to a file used by AMSS and AMSS2, it would be great appreciated. |
Hi @mmcky, this looks great to me! |
Summary
Upgrades build software and dependencies to align with lecture-python-intro.
Changes
environment.yml
.github/dependabot.yml
.github/workflows/ci.yml
lectures/_config.yml
Reference