Skip to content

Commit 146c30c

Browse files
Copilotmmcky
andauthored
Fix collapse functionality bugs: CSS selectors, height parsing, and toggle bar creation (#300)
* Initial plan * Initial analysis - understand collapse-## styling issue Co-authored-by: mmcky <[email protected]> * Fix collapse-## styling by removing hardcoded height Remove hardcoded height: 22.4rem from collapse CSS to allow JavaScript dynamic height control based on tag_collapse-## class names. Co-authored-by: mmcky <[email protected]> * Implement single bottom bar collapse toggle for better UX Replace separate "Show more/Show less" toggle links with integrated clickable bar at bottom of code cells. Maintains dynamic height control while providing more intuitive expand/collapse interaction. Co-authored-by: mmcky <[email protected]> * Relax Python version requirement from 3.13 to >=3.12 and update test matrix Co-authored-by: mmcky <[email protected]> * fix trim white space pre-commit * Fix collapse functionality - correct CSS selectors and height parsing logic Co-authored-by: mmcky <[email protected]> * Simplify collapse button text and add scroll behavior when collapsing Co-authored-by: mmcky <[email protected]> * fix: pre-commit * Improve collapse scroll behavior with better timing and comments Co-authored-by: mmcky <[email protected]> * Make collapse button text bold for better visibility Co-authored-by: mmcky <[email protected]> * fix pre-commit --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mmcky <[email protected]> Co-authored-by: mmcky <[email protected]> Co-authored-by: Matt McKay <[email protected]>
1 parent 988765c commit 146c30c

File tree

7 files changed

+6050
-6034
lines changed

7 files changed

+6050
-6034
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os: [ubuntu-latest]
25-
python-version: ["3.13"]
25+
python-version: ["3.12", "3.13"]
2626
# Only test the latest major release of Sphinx because otherwise we need to
2727
# keep multiple versions of regression tests on file and this creates lots of
2828
# noise in the tests.
@@ -48,7 +48,7 @@ jobs:
4848
pytest --durations=10 --cov=quantecon_book_theme --cov-report=xml --cov-report=term-missing
4949
5050
- name: Upload to Codecov
51-
if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.13 && github.repository == 'QuantEcon/quantecon-book-theme' && github.event_name == 'pull_request'
51+
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.13' && github.repository == 'QuantEcon/quantecon-book-theme' && github.event_name == 'pull_request'
5252
uses: codecov/[email protected]
5353
with:
5454
name: ebp-qbt-pytests-py3.13

0 commit comments

Comments
 (0)