Skip to content

Commit 2046ebc

Browse files
committed
Fix update-snapshots workflow: allow missing snapshot exits
The --update-snapshots=missing flag writes new snapshot files but still exits with code 1, causing the commit step to be skipped. Add continue-on-error so new baselines get committed.
1 parent 0358a7c commit 2046ebc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/update-snapshots.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ jobs:
7171
npx playwright install --with-deps chromium
7272
7373
- name: Update Snapshots
74+
# continue-on-error because --update-snapshots=missing writes new
75+
# baseline files but still reports them as test failures (exit code 1).
76+
# The commit step below will pick up the newly written snapshots.
77+
continue-on-error: true
7478
run: npx playwright test --update-snapshots=missing
7579
env:
7680
SITE_PATH: lecture-python-programming.myst/_build/html

0 commit comments

Comments
 (0)