refactor: rename definition_color to strong_color for accuracy

The option applies to all <strong>/<b> elements, not just definitions.
Sphinx renders actual definitions via <dl>/<dt> elements which can be
targeted separately. Renamed across SCSS, theme.conf, layout.html,
tests, and documentation.

Author: mmcky

docs/configure.md

@@ -338,8 +338,8 @@ html_theme_options = {
     ...
     "emphasis_color": "#1a73e8",
     "emphasis_color_dark": "#8ab4f8",
-    "definition_color": "#d93025",
-    "definition_color_dark": "#f28b82",
+    "strong_color": "#d93025",
+    "strong_color_dark": "#f28b82",
     ...
 }
 ```
@@ -352,15 +352,15 @@ sphinx:
     html_theme_options:
       emphasis_color: "#1a73e8"
       emphasis_color_dark: "#8ab4f8"
-      definition_color: "#d93025"
-      definition_color_dark: "#f28b82"
+      strong_color: "#d93025"
+      strong_color_dark: "#f28b82"
 ```
 
 | Option | Description | Default |
 |---|---|---|
 | `emphasis_color` | Color for `em` tags in light mode | `#2d9f42` (green) |
 | `emphasis_color_dark` | Color for `em` tags in dark mode | `#66bb6a` (light green) |
-| `definition_color` | Color for `strong`/`b` tags in light mode | `#8b4513` (brown) |
-| `definition_color_dark` | Color for `strong`/`b` tags in dark mode | `#cd853f` (peru) |
+| `strong_color` | Color for `strong`/`b` tags in light mode | `#8b4513` (brown) |
+| `strong_color_dark` | Color for `strong`/`b` tags in dark mode | `#cd853f` (peru) |
 
 Any option left empty will use the theme's built-in default color.

src/quantecon_book_theme/assets/styles/_base.scss

@@ -154,11 +154,11 @@ em {
   color: var(--qe-emphasis-color, colors.$emphasis);
 }
 
-// Strong/bold styling - semi-bold weight with color for definitions
+// Strong/bold styling - semi-bold weight with color
 strong,
 b {
   font-weight: 550;
-  color: var(--qe-definition-color, colors.$definition);
+  color: var(--qe-strong-color, colors.$definition);
 }
 
 li {

src/quantecon_book_theme/assets/styles/_dark-theme.scss

@@ -28,7 +28,7 @@ body.dark-theme {
 
   strong,
   b {
-    color: var(--qe-definition-color, #cd853f); // Lighter brown for dark mode
+    color: var(--qe-strong-color, #cd853f); // Lighter brown for dark mode
   }
 
   .qe-toolbar__inner > ul > li > a,

src/quantecon_book_theme/theme/quantecon_book_theme/layout.html

@@ -121,24 +121,24 @@
 </style>
 {%- endif %}
 
-<!-- Custom emphasis and definition colors -->
-{%- if theme_emphasis_color or theme_definition_color %}
+<!-- Custom emphasis and strong/bold colors -->
+{%- if theme_emphasis_color or theme_strong_color %}
 <style>
 :root {
   {%- if theme_emphasis_color %}
   --qe-emphasis-color: {{ theme_emphasis_color }};
   {%- endif %}
-  {%- if theme_definition_color %}
-  --qe-definition-color: {{ theme_definition_color }};
+  {%- if theme_strong_color %}
+  --qe-strong-color: {{ theme_strong_color }};
   {%- endif %}
 }
-{%- if theme_emphasis_color_dark or theme_definition_color_dark %}
+{%- if theme_emphasis_color_dark or theme_strong_color_dark %}
 body.dark-theme {
   {%- if theme_emphasis_color_dark %}
   --qe-emphasis-color: {{ theme_emphasis_color_dark }};
   {%- endif %}
-  {%- if theme_definition_color_dark %}
-  --qe-definition-color: {{ theme_definition_color_dark }};
+  {%- if theme_strong_color_dark %}
+  --qe-strong-color: {{ theme_strong_color_dark }};
   {%- endif %}
 }
 {%- endif %}

src/quantecon_book_theme/theme/quantecon_book_theme/theme.conf

@@ -39,5 +39,5 @@ use_repository_button = False
 
 emphasis_color =
 emphasis_color_dark =
-definition_color =
-definition_color_dark =
+strong_color =
+strong_color_dark =

tests/test_custom_colors.py

@@ -1,5 +1,5 @@
 """
-Tests for customizable emphasis and definition text colors.
+Tests for customizable emphasis and strong/bold text colors.
 
 Verifies that:
 - Theme options are registered in theme.conf
@@ -29,24 +29,24 @@ def test_emphasis_color_dark_option_exists(self):
         content = (THEME_DIR / "theme.conf").read_text()
         assert "emphasis_color_dark =" in content
 
-    def test_definition_color_option_exists(self):
-        """theme.conf should define definition_color option."""
+    def test_strong_color_option_exists(self):
+        """theme.conf should define strong_color option."""
         content = (THEME_DIR / "theme.conf").read_text()
-        assert "definition_color =" in content
+        assert "strong_color =" in content
 
-    def test_definition_color_dark_option_exists(self):
-        """theme.conf should define definition_color_dark option."""
+    def test_strong_color_dark_option_exists(self):
+        """theme.conf should define strong_color_dark option."""
         content = (THEME_DIR / "theme.conf").read_text()
-        assert "definition_color_dark =" in content
+        assert "strong_color_dark =" in content
 
     def test_options_default_to_empty(self):
         """All color options should default to empty (use CSS fallback)."""
         content = (THEME_DIR / "theme.conf").read_text()
         for option in [
             "emphasis_color",
             "emphasis_color_dark",
-            "definition_color",
-            "definition_color_dark",
+            "strong_color",
+            "strong_color_dark",
         ]:
             # Each option should appear as "option_name =" with no value
             # Use a targeted check to avoid matching substrings
@@ -55,53 +55,53 @@ def test_options_default_to_empty(self):
                 line for line in lines if line.strip().startswith(f"{option} =")
             ]
             assert len(matching) == 1, f"Expected exactly one '{option}' option"
-            assert matching[0].strip() == f"{option} =", (
-                f"'{option}' should default to empty string"
-            )
+            assert (
+                matching[0].strip() == f"{option} ="
+            ), f"'{option}' should default to empty string"
 
 
 class TestCustomColorCSSVariables:
-    """Test that SCSS uses CSS custom properties for emphasis/definition."""
+    """Test that SCSS uses CSS custom properties for emphasis/strong."""
 
     def test_base_scss_uses_emphasis_variable(self):
         """_base.scss should use --qe-emphasis-color CSS variable for em."""
         content = (ASSETS_DIR / "styles" / "_base.scss").read_text()
         assert "var(--qe-emphasis-color" in content
 
-    def test_base_scss_uses_definition_variable(self):
-        """_base.scss should use --qe-definition-color CSS variable for strong."""
+    def test_base_scss_uses_strong_variable(self):
+        """_base.scss should use --qe-strong-color CSS variable for strong."""
         content = (ASSETS_DIR / "styles" / "_base.scss").read_text()
-        assert "var(--qe-definition-color" in content
+        assert "var(--qe-strong-color" in content
 
     def test_base_scss_has_emphasis_fallback(self):
         """_base.scss should have SCSS fallback value for emphasis color."""
         content = (ASSETS_DIR / "styles" / "_base.scss").read_text()
         assert "var(--qe-emphasis-color, colors.$emphasis)" in content
 
-    def test_base_scss_has_definition_fallback(self):
-        """_base.scss should have SCSS fallback value for definition color."""
+    def test_base_scss_has_strong_fallback(self):
+        """_base.scss should have SCSS fallback value for strong color."""
         content = (ASSETS_DIR / "styles" / "_base.scss").read_text()
-        assert "var(--qe-definition-color, colors.$definition)" in content
+        assert "var(--qe-strong-color, colors.$definition)" in content
 
     def test_dark_theme_uses_emphasis_variable(self):
         """_dark-theme.scss should use --qe-emphasis-color CSS variable."""
         content = (ASSETS_DIR / "styles" / "_dark-theme.scss").read_text()
         assert "var(--qe-emphasis-color" in content
 
-    def test_dark_theme_uses_definition_variable(self):
-        """_dark-theme.scss should use --qe-definition-color CSS variable."""
+    def test_dark_theme_uses_strong_variable(self):
+        """_dark-theme.scss should use --qe-strong-color CSS variable."""
         content = (ASSETS_DIR / "styles" / "_dark-theme.scss").read_text()
-        assert "var(--qe-definition-color" in content
+        assert "var(--qe-strong-color" in content
 
     def test_dark_theme_has_emphasis_fallback(self):
         """_dark-theme.scss should have fallback for emphasis in dark mode."""
         content = (ASSETS_DIR / "styles" / "_dark-theme.scss").read_text()
         assert "var(--qe-emphasis-color, #66bb6a)" in content
 
-    def test_dark_theme_has_definition_fallback(self):
-        """_dark-theme.scss should have fallback for definition in dark mode."""
+    def test_dark_theme_has_strong_fallback(self):
+        """_dark-theme.scss should have fallback for strong in dark mode."""
         content = (ASSETS_DIR / "styles" / "_dark-theme.scss").read_text()
-        assert "var(--qe-definition-color, #cd853f)" in content
+        assert "var(--qe-strong-color, #cd853f)" in content
 
 
 class TestCustomColorCompiledCSS:
@@ -113,11 +113,11 @@ def test_compiled_css_has_emphasis_variable(self):
         content = css_path.read_text()
         assert "--qe-emphasis-color" in content
 
-    def test_compiled_css_has_definition_variable(self):
-        """Compiled CSS should contain --qe-definition-color variable."""
+    def test_compiled_css_has_strong_variable(self):
+        """Compiled CSS should contain --qe-strong-color variable."""
         css_path = THEME_DIR / "static" / "styles" / "quantecon-book-theme.css"
         content = css_path.read_text()
-        assert "--qe-definition-color" in content
+        assert "--qe-strong-color" in content
 
     def test_compiled_css_em_uses_variable(self):
         """Compiled CSS em rule should use var(--qe-emphasis-color)."""
@@ -126,10 +126,10 @@ def test_compiled_css_em_uses_variable(self):
         assert "var(--qe-emphasis-color" in content
 
     def test_compiled_css_strong_uses_variable(self):
-        """Compiled CSS strong rule should use var(--qe-definition-color)."""
+        """Compiled CSS strong rule should use var(--qe-strong-color)."""
         css_path = THEME_DIR / "static" / "styles" / "quantecon-book-theme.css"
         content = css_path.read_text()
-        assert "var(--qe-definition-color" in content
+        assert "var(--qe-strong-color" in content
 
 
 class TestCustomColorLayoutTemplate:
@@ -143,40 +143,40 @@ def test_template_checks_emphasis_color(self):
         content = self._read_layout()
         assert "theme_emphasis_color" in content
 
-    def test_template_checks_definition_color(self):
-        """Layout template should conditionally check theme_definition_color."""
+    def test_template_checks_strong_color(self):
+        """Layout template should conditionally check theme_strong_color."""
         content = self._read_layout()
-        assert "theme_definition_color" in content
+        assert "theme_strong_color" in content
 
     def test_template_checks_emphasis_color_dark(self):
         """Layout template should conditionally check theme_emphasis_color_dark."""
         content = self._read_layout()
         assert "theme_emphasis_color_dark" in content
 
-    def test_template_checks_definition_color_dark(self):
-        """Layout template should conditionally check theme_definition_color_dark."""
+    def test_template_checks_strong_color_dark(self):
+        """Layout template should conditionally check theme_strong_color_dark."""
         content = self._read_layout()
-        assert "theme_definition_color_dark" in content
+        assert "theme_strong_color_dark" in content
 
     def test_template_sets_emphasis_css_variable(self):
         """Layout template should set --qe-emphasis-color CSS variable."""
         content = self._read_layout()
         assert "--qe-emphasis-color: {{ theme_emphasis_color }}" in content
 
-    def test_template_sets_definition_css_variable(self):
-        """Layout template should set --qe-definition-color CSS variable."""
+    def test_template_sets_strong_css_variable(self):
+        """Layout template should set --qe-strong-color CSS variable."""
         content = self._read_layout()
-        assert "--qe-definition-color: {{ theme_definition_color }}" in content
+        assert "--qe-strong-color: {{ theme_strong_color }}" in content
 
     def test_template_sets_dark_emphasis_css_variable(self):
         """Layout template should set --qe-emphasis-color for dark mode."""
         content = self._read_layout()
         assert "--qe-emphasis-color: {{ theme_emphasis_color_dark }}" in content
 
-    def test_template_sets_dark_definition_css_variable(self):
-        """Layout template should set --qe-definition-color for dark mode."""
+    def test_template_sets_dark_strong_css_variable(self):
+        """Layout template should set --qe-strong-color for dark mode."""
         content = self._read_layout()
-        assert "--qe-definition-color: {{ theme_definition_color_dark }}" in content
+        assert "--qe-strong-color: {{ theme_strong_color_dark }}" in content
 
     def test_template_dark_mode_uses_body_dark_theme(self):
         """Layout template should target body.dark-theme for dark colors."""