Hotfix : missing math namespace for floating point equality check

small performance optimization (removed array slicing in the main loop)

Author: alaa-eddine

package.json

@@ -1,6 +1,6 @@
 {
     "name": "pinets",
-    "version": "0.2.0",
+    "version": "0.2.1",
     "description": "",
     "main": "dist/pinets.dev.es.js",
     "types": "dist/types/index.d.ts",

src/PineTS.class.ts

@@ -48,7 +48,7 @@ export class PineTS {
     ) {
         this._readyPromise = new Promise((resolve) => {
             this.loadMarketData(source, tickerId, timeframe, limit, sDate, eDate).then((data) => {
-                const marketData = data.reverse().slice(0, MAX_PERIODS);
+                const marketData = data.slice(0, MAX_PERIODS);
 
                 this._periods = marketData.length;
                 this.data = marketData;
@@ -115,21 +115,29 @@ export class PineTS {
         let transpiledFn = transformer(pineTSCode);
 
         //console.log('>>> transformedFn: ', transformedFn.toString());
-
+        context.data.close = [];
+        context.data.open = [];
+        context.data.high = [];
+        context.data.low = [];
+        context.data.volume = [];
+        context.data.hl2 = [];
+        context.data.hlc3 = [];
+        context.data.ohlc4 = [];
+        context.data.openTime = [];
+        context.data.closeTime = [];
         const contextVarNames = ['const', 'var', 'let', 'params'];
-        for (let i = this._periods - n, idx = n - 1; i < this._periods; i++, idx--) {
+        for (let i = this._periods - n; i < this._periods; i++) {
             context.idx = i;
 
-            context.data.close = this.close.slice(idx);
-            context.data.open = this.open.slice(idx);
-            context.data.high = this.high.slice(idx);
-            context.data.low = this.low.slice(idx);
-            context.data.volume = this.volume.slice(idx);
-            context.data.hl2 = this.hl2.slice(idx);
-            context.data.hlc3 = this.hlc3.slice(idx);
-            context.data.ohlc4 = this.ohlc4.slice(idx);
-            context.data.openTime = this.openTime.slice(idx);
-            context.data.closeTime = this.closeTime.slice(idx);
+            context.data.close.unshift(this.close[i]);
+            context.data.open.unshift(this.open[i]);
+            context.data.high.unshift(this.high[i]);
+            context.data.low.unshift(this.low[i]);
+            context.data.volume.unshift(this.volume[i]);
+            context.data.hl2.unshift(this.hl2[i]);
+            context.data.hlc3.unshift(this.hlc3[i]);
+            context.data.ohlc4.unshift(this.ohlc4[i]);
+            context.data.openTime.unshift(this.openTime[i]);
 
             const result = await transpiledFn(context);
 

src/namespaces/TechnicalAnalysis.ts

@@ -946,53 +946,6 @@ function rma(source: number[], period: number): number[] {
     return result;
 }
 
-function sma_cache(
-    source: number[],
-    period: number,
-    cacheObj: {
-        previousSum?: number;
-        lastProcessedIndex?: number;
-        previousResult?: number[];
-    }
-) {
-    const result = cacheObj.previousResult || new Array(source.length).fill(NaN);
-    const lastProcessedIndex = cacheObj.lastProcessedIndex || -1;
-    let previousSum = cacheObj.previousSum || 0;
-
-    if (lastProcessedIndex === -1 || source.length !== lastProcessedIndex + 1) {
-        // Initialize cache or handle reset/different length source
-        previousSum = 0;
-        for (let i = 0; i < period; i++) {
-            previousSum += source[i] || 0;
-        }
-        result[period - 1] = previousSum / period;
-
-        // Fill initial values with NaN for cache initialization as well
-        for (let i = 0; i < period - 1; i++) {
-            result[i] = NaN;
-        }
-
-        for (let i = period; i < source.length; i++) {
-            previousSum = previousSum - (source[i - period] || 0) + (source[i] || 0);
-            result[i] = previousSum / period;
-        }
-    } else if (source.length === lastProcessedIndex + 2) {
-        // Optimized calculation for new element
-        const newIndex = source.length - 1;
-        previousSum = previousSum - (source[newIndex - period] || 0) + (source[newIndex] || 0);
-        result[newIndex] = previousSum / period;
-    } else {
-        // Fallback to full calculation if cache is inconsistent or source length changed unexpectedly
-        return sma(source, period);
-    }
-
-    cacheObj.previousSum = previousSum;
-    cacheObj.lastProcessedIndex = source.length - 1;
-    cacheObj.previousResult = result;
-
-    return result;
-}
-
 function sma(source: number[], period: number): number[] {
     const result = new Array(source.length).fill(NaN);
 

src/transpiler/index.ts

@@ -1998,7 +1998,7 @@ function transformEqualityChecks(ast: any): void {
                         type: 'MemberExpression',
                         object: {
                             type: 'Identifier',
-                            name: 'math',
+                            name: '$.math',
                         },
                         property: {
                             type: 'Identifier',

tests/core/transpiler.test.ts

@@ -612,7 +612,7 @@ describe('Transpiler', () => {
     for (let i = 1; i <= avg_len[0]; i++) {
       $.let.fn2_ret_val[0] += avg_src[i];
     }
-    if (math.__eq(avg_len[0], 0)) {
+    if ($.math.__eq(avg_len[0], 0)) {
       $.let.fn2_ret_val[0] = $.let.fn2_cc[1];
     }
     return $.precision($.let.fn2_ret_val[0] / avg_len[0]);
@@ -701,7 +701,7 @@ describe('Transpiler', () => {
     for (let i = 1; i <= avg_len[0]; i++) {
       $.let.fn1_ret_val[0] += avg_src[i];
     }
-    if (math.__eq(avg_len[0], 0)) {
+    if ($.math.__eq(avg_len[0], 0)) {
       $.let.fn1_ret_val[0] = $.let.fn1_cc[1];
     }
     return $.precision($.let.fn1_ret_val[0] / avg_len[0]);