Fixed depth=0

Author: JohanMabille

src/subcommand/clone_subcommand.cpp

@@ -21,6 +21,20 @@ clone_subcommand::clone_subcommand(const libgit2_object&, CLI::App& app)
 
 void clone_subcommand::run()
 {
+    // m_depth = 0 means no shallow clone in libgit2, while
+    // it is forbidden with git. Therefore we use another
+    // sentinel value to detect full clone.
+    if (m_depth == 0)
+    {
+        std::cout << "fatal: depth 0 is not a positive number" << std::endl;
+        return;
+    }
+
+    if (m_depth == std::numeric_limits<size_t>::max())
+    {
+        m_depth = 0;
+    }
+
     git_indexer_progress pd;
     git_clone_options clone_opts = GIT_CLONE_OPTIONS_INIT;
     git_checkout_options checkout_opts = GIT_CHECKOUT_OPTIONS_INIT;
@@ -34,8 +48,6 @@ void clone_subcommand::run()
     clone_opts.fetch_opts.depth = m_depth;
     clone_opts.bare = m_bare ? 1 : 0;
 
-
-
     std::string short_name = m_directory;
     if (m_directory.empty())
     {

src/subcommand/clone_subcommand.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <CLI/CLI.hpp>
+#include <limits>
 
 #include "../utils/common.hpp"
 
@@ -16,7 +17,7 @@ class clone_subcommand
     std::string m_repository = {};
     std::string m_directory = {};
     bool m_bare = false;
-    size_t m_depth = 0;
+    size_t m_depth = std::numeric_limits<size_t>::max();
     // std::string m_shallow_since;
     // std::vector<std::string> m_shallow_exclude;
 };

test/test_remote.py

@@ -300,7 +300,7 @@ def test_fetch_from_remote(git2cpp_path, repo_with_remote):
     local_path, remote_path = repo_with_remote
 
     # Note: This is a bare repo with no refs, so fetch will fail gracefully
-    # For now, just test that fetch command runs (it will fail gracefully if no refs)
+    # For now, just test that  /stdofetch command runs (it will fail gracefully if no refs)
     cmd = [git2cpp_path, "fetch", "origin"]
     p = subprocess.run(cmd, capture_output=True, text=True, cwd=local_path)
     # Fetch might succeed (empty) or fail (no refs), but shouldn't crash
@@ -322,7 +322,8 @@ def test_fetch_depth(git2cpp_path, tmp_path, run_in_tmp_path):
 
     invalid_clone_cmd = [git2cpp_path, "clone", "--depth", "0", url]
     p_invalid_clone = subprocess.run(invalid_clone_cmd, capture_output=True, cwd=tmp_path, text=True)
-    assert p_invalid_clone.returncode != 0
+    assert p_invalid_clone.returncode == 0
+    assert p_invalid_clone.stdout.startswith(b'fatal: depth 0 is not a positive number')
 
     clone_cmd = [git2cpp_path, "clone", "--depth", "1", url]
     p_clone = subprocess.run(clone_cmd, capture_output=True, cwd=tmp_path, text=True)