Skip to content

Commit 16b6355

Browse files
committed
iterate on mounting drive functionality
1 parent 7ecd6fd commit 16b6355

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

jupyter_drives/managers/manager.py

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ async def mount_drive(self, drive_name, **kwargs):
114114
The content manager for the drive.
115115
"""
116116
try:
117-
# check if content manager didn't already exist
117+
# check if content manager doesn't already exist
118118
if drive_name not in self._content_managers or self._content_managers[drive_name] is None:
119119
if kwargs.provider == 's3':
120120
store = obs.store.S3Store.from_url("s3://" + drive_name + "/", config = {"aws_access_key_id": self._config.access_key_id, "aws_secret_access_key": self._config.secret_access_key, "aws_region": kwargs.drive_region})
@@ -128,21 +128,27 @@ async def mount_drive(self, drive_name, **kwargs):
128128
self._content_managers[drive_name].store = store
129129
self._content_managers[drive_name].provider = kwargs.provider
130130

131-
return store
132-
# response = {
133-
# "content_manager": store,
134-
# "code": 201,
135-
# "message": "Drive succesfully mounted."
136-
# }
137-
# else:
138-
# response = {
139-
# "code": 409,
140-
# "message": "Drive already mounted."
141-
# }
131+
response = {
132+
"content_manager": store,
133+
"code": 201,
134+
"message": "Drive succesfully mounted."
135+
}
136+
else:
137+
response = {
138+
"code": 409,
139+
"message": "Drive already mounted."
140+
}
142141
except Exception as e:
143-
raise ValueError("The following error occured when mouting the drive: {e}")
142+
response = {
143+
"code": 400,
144+
"message": "The following error occured when mouting the drive: {e}"
145+
}
146+
raise tornado.web.HTTPError(
147+
status_code= httpx.codes.BAD_REQUEST,
148+
reason= "The following error occured when mouting the drive: {e}"
149+
)
144150

145-
# return response
151+
return response
146152

147153
async def unmount_drive(self, drive_name: str, **kwargs):
148154
"""Unmount a drive.

0 commit comments

Comments
 (0)