update variable name

Author: DenisaCG

README.md

@@ -40,7 +40,7 @@ c.DrivesConfig.access_key_id = "<Drives Access Key ID / IAM Access Key ID>"
 c.DrivesConfig.secret_access_key = "<Drives Secret Access Key / IAM Secret>"
 c.DrivesConfig.session_token = "<Drives Session Token / IAM Session Token (optional)>"
 c.DrivesConfig.provider = "<Drives provider e.g.: s3, gcs>"
-c.DrivesConfig.max_files_shown = "<Integer repersenting maximum number of files that can be shown in a listing, given any path (optional)>"
+c.DrivesConfig.max_files_listed = "<Integer repersenting maximum number of files that can be shown in a listing, given any path (optional)>"
 ```
 
 ### Custom credentials file path
@@ -63,7 +63,7 @@ export JP_DRIVES_ACCESS_KEY_ID="<Drives Access Key ID>"
 export JP_DRIVES_SECRET_ACCESS_KEY="<Drives Secret Access Key>"
 export JP_DRIVES_SESSION_TOKEN="<Drives Session Token (optional)>"
 export JP_DRIVES_CUSTOM_CREDENTIALS_PATH="<Path to local file which contains credentials (optional)>"
-export JP_DRIVES_MAX_FILES_SHOWN="<Integer repersenting maximum number of files that can be shown in a listing, given any path (optional)>"
+export JP_DRIVES_MAX_FILES_LISTED="<Integer repersenting maximum number of files that can be shown in a listing, given any path (optional)>"
 ```
 
 ## Uninstall

jupyter_drives/base.py

@@ -59,7 +59,7 @@ class DrivesConfig(Configurable):
         help="Custom path of file where credentials are located. Extension automatically checks jupyter_notebook_config.py or directly in ~/.aws/credentials for AWS CLI users."
     )
 
-    max_files_shown = Int(
+    max_files_listed = Int(
         None,
         config = True,
         allow_none = True,
@@ -89,11 +89,11 @@ def __init__(self, **kwargs):
 
     def _load_credentials(self):
         # check if max_files_shown is not set in jupyter_notebook_config.py
-        if self.max_files_shown is None:
-            if "JP_DRIVES_MAX_FILES_SHOWN" in os.environ:
-                self.max_files_shown = os.environ["JP_DRIVES_MAX_FILES_SHOWN"]
+        if self.max_files_listed is None:
+            if "JP_DRIVES_MAX_FILES_LISTED" in os.environ:
+                self.max_files_listed = os.environ["JP_DRIVES_MAX_FILES_LISTED"]
             else:
-                self.max_files_shown = 1000
+                self.max_files_listed = 1000
 
         # check if credentials were already set in jupyter_notebook_config.py
         if self.access_key_id is not None and self.secret_access_key is not None:
@@ -103,7 +103,7 @@ def _load_credentials(self):
         if self.custom_credentials_path is None and "JP_DRIVES_CUSTOM_CREDENTIALS_PATH" in os.environ:
             self.custom_credentials_path = os.environ["JP_DRIVES_CUSTOM_CREDENTIALS_PATH"]
         if self.custom_credentials_path is not None:
-            self.provider, self.access_key_id, self.secret_access_key, self.session_token, self.max_files_shown = self._extract_credentials_from_file(self.custom_credentials_path)
+            self.provider, self.access_key_id, self.secret_access_key, self.session_token, self.max_files_listed = self._extract_credentials_from_file(self.custom_credentials_path)
             return
 
         # if not, try to load credentials from AWS CLI
@@ -126,7 +126,7 @@ def _extract_credentials_from_file(self, file_path):
         try:
             with open(file_path, 'r') as file:
                 provider, access_key_id, secret_access_key, session_token = None, None, None, None
-                max_files_shown = 1000
+                max_files_listed = 1000
                 lines = file.readlines()
                 for line in lines:
                     if line.startswith("drives_provider ="):
@@ -138,8 +138,8 @@ def _extract_credentials_from_file(self, file_path):
                     elif line.startswith("drives_session_token ="):
                         session_token = line.split("=")[1].strip()
                     elif line.startswith("drives_max_files_shwon ="):
-                        max_files_shown = line.split("=")[1].strip()
-                return provider, access_key_id, secret_access_key, session_token, max_files_shown
+                        max_files_listed = line.split("=")[1].strip()
+                return provider, access_key_id, secret_access_key, session_token, max_files_listed
         except Exception as e:
             print(f"Failed loading credentials from {file_path}: {e}")
         return

jupyter_drives/manager.py

@@ -194,9 +194,9 @@ async def get_contents(self, drive_name, path):
             emptyDir = True # assume we are dealing with an empty directory
 
             chunk_size = 100
-            if self._config.max_files_shown < chunk_size:
-                chunk_size = self._config.max_files_shown
-            no_batches = int(self._config.max_files_shown/chunk_size)
+            if self._config.max_files_listed < chunk_size:
+                chunk_size = self._config.max_files_listed
+            no_batches = int(self._config.max_files_listed/chunk_size)
 
             # using Arrow lists as they are recommended for large results
             # stream will be an async iterable of RecordBatch
@@ -206,7 +206,7 @@ async def get_contents(self, drive_name, path):
                 current_batch += 1
                 # reached last batch that can be shown (partially)
                 if current_batch == no_batches + 1:
-                    remaining_files = self._config.max_files_shown - no_batches*chunk_size
+                    remaining_files = self._config.max_files_listed - no_batches*chunk_size
 
                 # if content exists we are dealing with a directory
                 if isDir is False and batch: