Skip to content

Commit bd3e468

Browse files
committed
update commands visibility
1 parent 1e0cbf2 commit bd3e468

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/plugins/driveBrowserPlugin.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ export const driveFileBrowser: JupyterFrontEndPlugin<void> = {
113113
driveBrowser.title.icon = driveBrowserIcon;
114114
driveBrowser.title.caption = 'Drive File Browser';
115115
driveBrowser.id = 'drive-file-browser';
116+
driveBrowser.addClass('drive-browser');
116117

117118
void Private.restoreBrowser(driveBrowser, commands, router, tree, labShell);
118119

@@ -154,9 +155,9 @@ export const driveFileBrowser: JupyterFrontEndPlugin<void> = {
154155
const updateVisibility = () => {
155156
// Visibility of context menu and toolbar commands changed.
156157
if (driveBrowser.model.path !== 's3:') {
157-
uploader.show();
158+
uploader.enabled = true;
158159
} else {
159-
uploader.hide();
160+
uploader.enabled = false;
160161
}
161162
app.commands.notifyCommandChanged(CommandIDs.createNewDrive);
162163
app.commands.notifyCommandChanged(CommandIDs.createNewDirectory);
@@ -335,7 +336,7 @@ namespace Private {
335336
browser: FileBrowser
336337
): void {
337338
app.commands.addCommand(CommandIDs.createNewDrive, {
338-
isVisible: () => {
339+
isEnabled: () => {
339340
return browser.model.path === 's3:';
340341
},
341342
execute: async () => {
@@ -363,7 +364,7 @@ namespace Private {
363364
app.contextMenu.addItem({
364365
command: CommandIDs.createNewDrive,
365366
selector: '#drive-file-browser.jp-SidePanel .jp-DirListing-content',
366-
rank: 100
367+
rank: 105
367368
});
368369

369370
app.commands.addCommand(CommandIDs.toggleFileFilter, {
@@ -381,7 +382,7 @@ namespace Private {
381382
});
382383

383384
app.commands.addCommand(CommandIDs.createNewDirectory, {
384-
isVisible: () => {
385+
isEnabled: () => {
385386
return browser.model.path !== 's3:';
386387
},
387388
execute: () => {
@@ -392,7 +393,7 @@ namespace Private {
392393
});
393394

394395
app.commands.addCommand(CommandIDs.createNewFile, {
395-
isVisible: () => {
396+
isEnabled: () => {
396397
return browser.model.path !== 's3:';
397398
},
398399
execute: () => {
@@ -403,7 +404,7 @@ namespace Private {
403404
});
404405

405406
app.commands.addCommand(CommandIDs.createNewNotebook, {
406-
isVisible: () => {
407+
isEnabled: () => {
407408
return browser.model.path !== 's3:';
408409
},
409410
execute: () => {

0 commit comments

Comments
 (0)