Skip to content

Commit 010112a

Browse files
committed
Fix according review
1 parent 85569fd commit 010112a

File tree

7 files changed

+34
-12
lines changed

7 files changed

+34
-12
lines changed

.github/copilot-instructions.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,3 @@ See `integration_tests/CMakeLists.txt` for examples. Missing this causes "cannot
5151
- `m_` prefix for members
5252
- Namespace: `sparrow_ipc`
5353
- Format: `cmake --build build --target clang-format` (requires `ACTIVATE_LINTER=ON`)
54-
55-
## Common Issues
56-
57-
1. Schema mismatches in stream → `std::invalid_argument`
58-
2. Deallocating source buffer while arrays in use → undefined behavior
59-
3. Missing RPATH on Linux → runtime linking errors
60-
4. Only LZ4 compression supported (not ZSTD yet)

.github/workflows/integration_tests.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ jobs:
4646
working-directory: build
4747
run: cmake --build . --config Release --target arrow_validate
4848

49-
- name: List all folders and subfolders
50-
run: |
51-
echo "Listing all folders and subfolders:"
52-
find . -type d
5349

5450
- name: Build Docker image
5551
run: docker build -t sparrow/integration-tests -f ci/docker/integration.dockerfile .

.github/workflows/linux.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,14 @@ jobs:
103103
working-directory: build
104104
run: cmake --build . --target run_example
105105

106+
- name: Build test_integration_tools
107+
working-directory: build
108+
run: cmake --build . --target test_integration_tools
109+
110+
- name: Run test_integration_tools
111+
working-directory: build
112+
run: cmake --build . --target run_test_integration_tools
113+
106114
- name: Install
107115
working-directory: build
108116
run: sudo cmake --install .

.github/workflows/osx.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,14 @@ jobs:
6464
working-directory: build
6565
run: cmake --build . --target run_example
6666

67+
- name: Build test_integration_tools
68+
working-directory: build
69+
run: cmake --build . --target test_integration_tools
70+
71+
- name: Run test_integration_tools
72+
working-directory: build
73+
run: cmake --build . --target run_test_integration_tools
74+
6775
- name: Install
6876
working-directory: build
6977
run: cmake --install .

.github/workflows/windows.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,13 @@ jobs:
6464
working-directory: build
6565
run: cmake --build . --config ${{ matrix.build_type }} --target run_example
6666

67+
- name: Build test_integration_tools
68+
working-directory: build
69+
run: cmake --build . --config ${{ matrix.build_type }} --target test_integration_tools
70+
71+
- name: Run test_integration_tools
72+
working-directory: build
73+
run: cmake --build . --config ${{ matrix.build_type }} --target run_test_integration_tools
6774
- name: Install
6875
working-directory: build
6976
run: cmake --install . --config ${{ matrix.build_type }}

integration_tests/CMakeLists.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,16 @@ target_include_directories(test_integration_tools
157157
${CMAKE_BINARY_DIR}/generated
158158
)
159159

160+
add_custom_target(run_test_integration_tools
161+
COMMAND test_integration_tools
162+
DEPENDS
163+
test_integration_tools
164+
COMMENT "Running tests"
165+
USES_TERMINAL
166+
)
167+
168+
set_target_properties(run_test_integration_tools PROPERTIES FOLDER "Tests utilities")
169+
160170
# Register with CTest
161171
enable_testing()
162172
add_test(NAME integration_tools_test COMMAND test_integration_tools)

src/serialize.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace sparrow_ipc
4747
//
4848
// Arrow's WriteMessage returns metadata_length = align_to_8(8 + flatbuffer_size)
4949
// which INCLUDES the continuation bytes.
50-
50+
5151
// Write metadata
5252
common_serialize(builder, stream);
5353

0 commit comments

Comments
 (0)