Skip to content

Commit 0bde65e

Browse files
committed
Not use sparrow-ipc files
1 parent 7cb50ab commit 0bde65e

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ set(SPARROW_IPC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src)
3131
set(SPARROW_IPC_HEADERS
3232
${SPARROW_IPC_INCLUDE_DIR}/config/config.hpp
3333
${SPARROW_IPC_INCLUDE_DIR}/serialize.hpp
34-
${SPARROW_IPC_INCLUDE_DIR}/sparrow-ipc.hpp
3534
)
3635

3736
set(SPARROW_IPC_SRC
3837
${SPARROW_IPC_SOURCE_DIR}/serialize.cpp
39-
${SPARROW_IPC_SOURCE_DIR}/sparrow-ipc.cpp
4038
)
4139

4240
set(SCHEMA_DIR ${CMAKE_BINARY_DIR}/format)

include/serialize.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
#include <vector>
44
#include "sparrow.hpp"
55

6+
#include "config/config.hpp"
7+
68
//TODO split serialize/deserialize fcts in two different files or just rename the current one?
79
template <typename T>
8-
std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr);
10+
SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr);
911

1012
template <typename T>
11-
sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer);
13+
SPARROW_IPC_API sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer);

src/serialize.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
#include <string_view>
77
#include <vector>
88

9-
#include "../include/config/config.hpp"
10-
119
#include "Message_generated.h"
1210
#include "Schema_generated.h"
1311

@@ -49,7 +47,7 @@ namespace
4947
}
5048

5149
template <typename T>
52-
SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr)
50+
std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr)
5351
{
5452
// This function serializes a sparrow::primitive_array into a byte vector that is compliant
5553
// with the Apache Arrow IPC Streaming Format. It constructs a stream containing two messages:
@@ -226,7 +224,7 @@ SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array(const sparrow::pr
226224
}
227225

228226
template <typename T>
229-
SPARROW_IPC_API sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer) {
227+
sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer) {
230228
const uint8_t* buf_ptr = buffer.data();
231229
size_t current_offset = 0;
232230

src/sparrow-ipc.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
#include "../include/sparrow-ipc.hpp"
44
#include "../generated/Schema_generated.h"
55

6+
// TODO remove this file and its header
67
void fake_func_for_now()
78
{}

0 commit comments

Comments
 (0)