Skip to content

Commit 2953f10

Browse files
Alex-PLACETCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent 99dc1e1 commit 2953f10

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

include/sparrow_ipc/serialize.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ namespace sparrow_ipc
2323
int32_t metadata_length; ///< Length of the metadata (FlatBuffer message + padding)
2424
int64_t body_length; ///< Length of the record batch body (data buffers)
2525
};
26-
}
27-
28-
namespace sparrow_ipc
29-
{
3026
/**
3127
* @brief Serializes a collection of record batches into a binary format.
3228
*

integration_tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ set_target_properties(arrow_validate
132132
CXX_EXTENSIONS OFF
133133
VERSION ${SPARROW_IPC_BINARY_VERSION}
134134
SOVERSION ${SPARROW_IPC_BINARY_CURRENT}
135-
FOLDER integration_tests
135+
FOLDER "Integration Tests"
136136
BUILD_RPATH_USE_ORIGIN ON
137137
BUILD_RPATH "$ORIGIN"
138138
INSTALL_RPATH "$ORIGIN"

integration_tests/src/integration_tools.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ namespace integration_tools
283283

284284
if (arrow_file_data.empty())
285285
{
286-
throw std::runtime_error("Stream data is empty");
286+
throw std::runtime_error("Arrow file data is empty");
287287
}
288288

289289
std::vector<sparrow::record_batch> stream_batches;
@@ -293,7 +293,7 @@ namespace integration_tools
293293
}
294294
catch (const std::exception& e)
295295
{
296-
throw std::runtime_error("Failed to deserialize stream: " + std::string(e.what()));
296+
throw std::runtime_error("Failed to deserialize Arrow file: " + std::string(e.what()));
297297
}
298298

299299
if (json_batches.size() != stream_batches.size())

0 commit comments

Comments
 (0)