Skip to content

Commit 39942cc

Browse files
committed
Add SPARROW_IPC_EXPORTS to cmake file
1 parent 4edc7e4 commit 39942cc

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,13 @@ find_package(sparrow CONFIG REQUIRED)
101101

102102
add_library(sparrow-ipc ${SPARROW_IPC_LIBRARY_TYPE} ${SPARROW_IPC_SRC} ${SPARROW_IPC_HEADERS})
103103
target_compile_definitions(sparrow-ipc PUBLIC ${SPARROW_IPC_COMPILE_DEFINITIONS})
104+
105+
if(UNIX)
106+
target_compile_options(sparrow-ipc PRIVATE "-fvisibility=hidden")
107+
else()
108+
target_compile_definitions(sparrow-ipc PRIVATE SPARROW_IPC_EXPORTS)
109+
endif()
110+
104111
target_include_directories(sparrow-ipc PUBLIC ${SPARROW_IPC_INCLUDE_DIR} PRIVATE ${SPARROW_IPC_SOURCE_DIR} )
105112
target_link_libraries(sparrow-ipc PRIVATE flatbuffers_interface)
106113
target_link_libraries(sparrow-ipc PUBLIC flatbuffers::flatbuffers sparrow::sparrow)

src/serialize.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace
4747
}
4848

4949
template <typename T>
50-
SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr)
50+
std::vector<uint8_t> serialize_primitive_array(const sparrow::primitive_array<T>& arr)
5151
{
5252
// This function serializes a sparrow::primitive_array into a byte vector that is compliant
5353
// with the Apache Arrow IPC Streaming Format. It constructs a stream containing two messages:
@@ -224,7 +224,7 @@ SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array(const sparrow::pr
224224
}
225225

226226
template <typename T>
227-
SPARROW_IPC_API sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer) {
227+
sparrow::primitive_array<T> deserialize_primitive_array(const std::vector<uint8_t>& buffer) {
228228
const uint8_t* buf_ptr = buffer.data();
229229
size_t current_offset = 0;
230230

@@ -306,4 +306,4 @@ template SPARROW_IPC_API sparrow::primitive_array<int> deserialize_primitive_arr
306306
template SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array<float>(const sparrow::primitive_array<float>& arr);
307307
template SPARROW_IPC_API sparrow::primitive_array<float> deserialize_primitive_array<float>(const std::vector<uint8_t>& buffer);
308308
template SPARROW_IPC_API std::vector<uint8_t> serialize_primitive_array<double>(const sparrow::primitive_array<double>& arr);
309-
template SPARROW_IPC_API sparrow::primitive_array<double> deserialize_primitive_array<double>(const std::vector<uint8_t>& buffer);
309+
template SPARROW_IPC_API sparrow::primitive_array<double> deserialize_primitive_array<double>(const std::vector<uint8_t>& buffer);

0 commit comments

Comments
 (0)