Skip to content

Commit 4129fe3

Browse files
committed
Test offending line after fix on sparrow
1 parent 1841ef1 commit 4129fe3

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

tests/test_primitive_array_serialization.cpp

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -123,20 +123,22 @@ namespace sparrow_ipc
123123
template <typename T>
124124
void compare_primitive_arrays(sp::primitive_array<T>& ar, sp::primitive_array<T>& deserialized_ar)
125125
{
126-
const auto [arrow_array_ar, arrow_schema_ar] = sp::get_arrow_structures(ar);
127-
const auto [arrow_array_deserialized_ar, arrow_schema_deserialized_ar] = sp::get_arrow_structures(deserialized_ar);
128-
129-
// Check ArrowSchema equality
130-
REQUIRE_NE(arrow_schema_ar, nullptr);
131-
REQUIRE_NE(arrow_schema_deserialized_ar, nullptr);
132-
compare_arrow_schemas(*arrow_schema_ar, *arrow_schema_deserialized_ar);
133-
134-
// Check ArrowArray equality
135-
REQUIRE_NE(arrow_array_ar, nullptr);
136-
REQUIRE_NE(arrow_array_deserialized_ar, nullptr);
137-
compare_arrow_arrays(*arrow_array_ar, *arrow_array_deserialized_ar);
126+
// const auto [arrow_array_ar, arrow_schema_ar] = sp::get_arrow_structures(ar);
127+
// const auto [arrow_array_deserialized_ar, arrow_schema_deserialized_ar] = sp::get_arrow_structures(deserialized_ar);
128+
//
129+
// // Check ArrowSchema equality
130+
// REQUIRE_NE(arrow_schema_ar, nullptr);
131+
// REQUIRE_NE(arrow_schema_deserialized_ar, nullptr);
132+
// compare_arrow_schemas(*arrow_schema_ar, *arrow_schema_deserialized_ar);
133+
//
134+
// // Check ArrowArray equality
135+
// REQUIRE_NE(arrow_array_ar, nullptr);
136+
// REQUIRE_NE(arrow_array_deserialized_ar, nullptr);
137+
// compare_arrow_arrays(*arrow_array_ar, *arrow_array_deserialized_ar);
138138

139139
// compare_values<T>(ar, deserialized_ar);
140+
141+
CHECK_EQ(ar, deserialized_ar);
140142
compare_bitmap<T>(ar, deserialized_ar);
141143
compare_metadata(ar, deserialized_ar);
142144
}

0 commit comments

Comments
 (0)