Skip to content

Commit 745e660

Browse files
committed
Remove unnecessary code
1 parent 9f3f3fc commit 745e660

File tree

3 files changed

+6
-24
lines changed

3 files changed

+6
-24
lines changed

CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,15 @@ MESSAGE(STATUS "🔧 Build tests: ${SPARROW_IPC_BUILD_TESTS}")
4747
OPTION(BUILD_DOCS "Build sparrow-ipc documentation" OFF)
4848
MESSAGE(STATUS "🔧 Build docs: ${BUILD_DOCS}")
4949

50+
# Code coverage
51+
# =============
5052
OPTION(SPARROW_IPC_ENABLE_COVERAGE "Enable test coverage" OFF)
5153
MESSAGE(STATUS "🔧 Enable coverage: ${SPARROW_IPC_ENABLE_COVERAGE}")
5254

55+
if(SPARROW_IPC_ENABLE_COVERAGE)
56+
include(code_coverage)
57+
endif()
58+
5359
set(SPARROW_IPC_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include)
5460
set(SPARROW_IPC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src)
5561

@@ -159,10 +165,6 @@ target_link_libraries(sparrow-ipc
159165

160166
add_dependencies(sparrow-ipc generate_flatbuffers_headers)
161167

162-
if(SPARROW_IPC_ENABLE_COVERAGE)
163-
include(code_coverage)
164-
#enable_coverage(sparrow-ipc)
165-
endif()
166168
# Tests
167169
# =====
168170
if(SPARROW_IPC_BUILD_TESTS)

cmake/code_coverage.cmake

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ set(COBERTURA_REPORT_PATH "${COVERAGE_REPORT_PATH}/cobertura.xml" CACHE PATH "Pa
77
set(COVERAGE_TARGETS_FOLDER "Tests utilities/Code Coverage")
88

99
if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
10-
message(STATUS "==============> Using MSVC")
1110
find_program(OpenCPPCoverage OpenCppCoverage.exe opencppcoverage.exe REQUIRED
1211
PATHS "C:/Program Files/OpenCppCoverage" "C:/Program Files (x86)/OpenCppCoverage")
1312

@@ -33,19 +32,4 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
3332
COMMENT "Generating coverage report with OpenCppCoverage: ${COVERAGE_REPORT_PATH}"
3433
)
3534
set(TARGET_PROPERTIES sparrow_ipc_generate_cobertura PROPERTIES FOLDER "Tests utilities/Code Coverage")
36-
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
37-
message(STATUS "==============> Using Clang or GNU")
3835
endif()
39-
40-
#TODO this may not be useful if coverage only on Windows ci?
41-
# function(enable_coverage target)
42-
# set(CLANG_COVERAGE_FLAGS --coverage -fprofile-instr-generate -fcoverage-mapping -fno-inline -fno-elide-constructors)
43-
# set(GCC_COVERAGE_FLAGS --coverage -fno-inline -fno-inline-small-functions -fno-default-inline)
44-
#
45-
# target_compile_options(${target} PRIVATE
46-
# $<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
47-
# $<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
48-
# target_link_options(${target} PRIVATE
49-
# $<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
50-
# $<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
51-
# endfunction(enable_coverage target)

tests/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ set(
1414

1515
add_executable(${test_target} ${SPARROW_IPC_TESTS_SRC})
1616

17-
# if(ENABLE_COVERAGE)
18-
# enable_coverage(${test_target})
19-
# endif()
20-
2117
target_link_libraries(${test_target}
2218
PRIVATE
2319
sparrow-ipc

0 commit comments

Comments
 (0)