wip

Author: Alex-PLACET

include/sparrow_ipc/deserialize_fixedsizebinary_array.hpp

@@ -15,6 +15,7 @@ namespace sparrow_ipc
         std::span<const uint8_t> body,
         std::string_view name,
         const std::optional<std::vector<sparrow::metadata_pair>>& metadata,
+        bool nullable,
         size_t& buffer_index,
         int32_t byte_width
     );

include/sparrow_ipc/deserialize_primitive_array.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <optional>
+#include <unordered_set>
 #include <vector>
 
 #include <sparrow/arrow_interface/arrow_array_schema_proxy.hpp>
@@ -19,17 +20,26 @@ namespace sparrow_ipc
         std::span<const uint8_t> body,
         std::string_view name,
         const std::optional<std::vector<sparrow::metadata_pair>>& metadata,
+        bool nullable,
         size_t& buffer_index
     )
     {
         const std::string_view format = data_type_to_format(
             sparrow::detail::get_data_type_from_array<sparrow::primitive_array<T>>::get()
         );
+        
+        // Set up flags based on nullable
+        std::optional<std::unordered_set<sparrow::ArrowFlag>> flags;
+        if (nullable)
+        {
+            flags = std::unordered_set<sparrow::ArrowFlag>{sparrow::ArrowFlag::NULLABLE};
+        }
+        
         ArrowSchema schema = make_non_owning_arrow_schema(
             format,
             name.data(),
             metadata,
-            std::nullopt,
+            flags,
             0,
             nullptr,
             nullptr

include/sparrow_ipc/deserialize_variable_size_binary_array.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <span>
+#include <unordered_set>
 
 #include <sparrow/arrow_interface/arrow_array_schema_proxy.hpp>
 #include <sparrow/variable_size_binary_array.hpp>
@@ -18,15 +19,24 @@ namespace sparrow_ipc
         std::span<const uint8_t> body,
         std::string_view name,
         const std::optional<std::vector<sparrow::metadata_pair>>& metadata,
+        bool nullable,
         size_t& buffer_index
     )
     {
         const std::string_view format = data_type_to_format(sparrow::detail::get_data_type_from_array<T>::get());
+        
+        // Set up flags based on nullable
+        std::optional<std::unordered_set<sparrow::ArrowFlag>> flags;
+        if (nullable)
+        {
+            flags = std::unordered_set<sparrow::ArrowFlag>{sparrow::ArrowFlag::NULLABLE};
+        }
+        
         ArrowSchema schema = make_non_owning_arrow_schema(
             format,
             name.data(),
             metadata,
-            std::nullopt,
+            flags,
             0,
             nullptr,
             nullptr