review

Author: Alex-PLACET

include/sparrow_ipc/magic_values.hpp

@@ -11,13 +11,13 @@ namespace sparrow_ipc
      * Continuation value defined in the Arrow IPC specification:
      * https://arrow.apache.org/docs/format/Columnar.html#encapsulated-message-format
      */
-    constexpr std::array<std::uint8_t, 4> continuation = {0xFF, 0xFF, 0xFF, 0xFF};
+    inline constexpr std::array<std::uint8_t, 4> continuation = {0xFF, 0xFF, 0xFF, 0xFF};
 
     /**
      * End-of-stream marker defined in the Arrow IPC specification:
      * https://arrow.apache.org/docs/format/Columnar.html#ipc-streaming-format
      */
-    constexpr std::array<std::uint8_t, 8> end_of_stream = {0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00};
+    inline constexpr std::array<std::uint8_t, 8> end_of_stream = {0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00};
 
     template <std::ranges::input_range R>
     [[nodiscard]] bool is_continuation(const R& buf)

include/sparrow_ipc/serialize.hpp

@@ -51,7 +51,7 @@ namespace sparrow_ipc
             );
         }
         std::vector<uint8_t> serialized_schema = serialize_schema_message(record_batches[0]);
-        std::vector<uint8_t> serialized_record_batches = serialize_record_batches(record_batches);
+        std::vector<uint8_t> serialized_record_batches = serialize_record_batches_without_schema_message(record_batches);
         serialized_schema.insert(
             serialized_schema.end(),
             std::make_move_iterator(serialized_record_batches.begin()),

include/sparrow_ipc/serialize_utils.hpp

@@ -64,7 +64,7 @@ namespace sparrow_ipc
      * @note The function uses move iterators to efficiently transfer the serialized data
      *       from individual record batches to the output vector.
      */
-    [[nodiscard]] std::vector<uint8_t> serialize_record_batches(const R& record_batches)
+    [[nodiscard]] std::vector<uint8_t> serialize_record_batches_without_schema_message(const R& record_batches)
     {
         std::vector<uint8_t> output;
         for (const auto& record_batch : record_batches)