Skip to content

Commit 9c32fc0

Browse files
committed
wip
1 parent 5b779ba commit 9c32fc0

File tree

4 files changed

+176
-244
lines changed

4 files changed

+176
-244
lines changed

include/sparrow_ipc/arrow_interface/arrow_array.hpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55

66
#include <sparrow/c_interface.hpp>
77

8+
#include "sparrow_ipc/config/config.hpp"
9+
810
namespace sparrow_ipc
911
{
10-
[[nodiscard]] ArrowArray make_non_owning_arrow_array(
12+
[[nodiscard]] SPARROW_IPC_API ArrowArray make_non_owning_arrow_array(
1113
int64_t length,
1214
int64_t null_count,
1315
int64_t offset,
@@ -17,9 +19,9 @@ namespace sparrow_ipc
1719
ArrowArray* dictionary
1820
);
1921

20-
void release_non_owning_arrow_array(ArrowArray* array);
22+
SPARROW_IPC_API void release_non_owning_arrow_array(ArrowArray* array);
2123

22-
void fill_non_owning_arrow_array(
24+
SPARROW_IPC_API void fill_non_owning_arrow_array(
2325
ArrowArray& array,
2426
int64_t length,
2527
int64_t null_count,

include/sparrow_ipc/arrow_interface/arrow_schema.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77
#include <sparrow/utils/contracts.hpp>
88
#include <sparrow/utils/metadata.hpp>
99

10-
#include "arrow_schema/private_data.hpp"
10+
#include "sparrow_ipc/arrow_interface/arrow_schema/private_data.hpp"
11+
#include "sparrow_ipc/config/config.hpp"
1112

1213
namespace sparrow_ipc
1314
{
14-
void release_non_owning_arrow_schema(ArrowSchema* schema);
15+
SPARROW_IPC_API void release_non_owning_arrow_schema(ArrowSchema* schema);
1516

1617
template <sparrow::input_metadata_container M = std::vector<sparrow::metadata_pair>>
1718
void fill_non_owning_arrow_schema(

include/sparrow_ipc/deserialize_primitive_array.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
namespace sparrow_ipc
1515
{
1616
template <typename T>
17-
[[nodiscard]] sparrow::primitive_array<T> deserialize_primitive_array_bis(
17+
[[nodiscard]] sparrow::primitive_array<T> deserialize_non_owning_primitive_array(
1818
const org::apache::arrow::flatbuf::RecordBatch& record_batch,
1919
std::span<const uint8_t> body,
2020
std::string_view name,

0 commit comments

Comments
 (0)