Skip to content

Commit b5b3d97

Browse files
Alex-PLACETAlex-PLACET
committed
Fix name
1 parent 08e0183 commit b5b3d97

File tree

5 files changed

+50
-50
lines changed

5 files changed

+50
-50
lines changed

‎include/sparrow_ipc/chunk_memory_output_stream.hpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ namespace sparrow_ipc
1111
requires std::ranges::random_access_range<R>
1212
&& std::ranges::random_access_range<std::ranges::range_value_t<R>>
1313
&& std::same_as<typename std::ranges::range_value_t<R>::value_type, uint8_t>
14-
class chuncked_memory_output_stream final : public output_stream
14+
class chunked_memory_output_stream final : public output_stream
1515
{
1616
public:
1717

18-
explicit chuncked_memory_output_stream(R& chunks)
18+
explicit chunked_memory_output_stream(R& chunks)
1919
: m_chunks(&chunks) {};
2020

2121
std::size_t write(std::span<const std::uint8_t> span) override

‎include/sparrow_ipc/chunk_memory_serializer.hpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ namespace sparrow_ipc
1616

1717
chunk_serializer(
1818
const sparrow::record_batch& rb,
19-
chuncked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
19+
chunked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
2020
);
2121

2222
template <std::ranges::input_range R>
2323
requires std::same_as<std::ranges::range_value_t<R>, sparrow::record_batch>
2424
chunk_serializer(
2525
const R& record_batches,
26-
chuncked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
26+
chunked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
2727
)
2828
: m_pstream(&stream)
2929
{
@@ -68,7 +68,7 @@ namespace sparrow_ipc
6868
private:
6969

7070
std::vector<sparrow::data_type> m_dtypes;
71-
chuncked_memory_output_stream<std::vector<std::vector<uint8_t>>>* m_pstream;
71+
chunked_memory_output_stream<std::vector<std::vector<uint8_t>>>* m_pstream;
7272
bool m_ended{false};
7373
};
7474
}

‎src/chunk_memory_serializer.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace sparrow_ipc
77
{
88
chunk_serializer::chunk_serializer(
99
const sparrow::record_batch& rb,
10-
chuncked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
10+
chunked_memory_output_stream<std::vector<std::vector<uint8_t>>>& stream
1111
)
1212
: m_pstream(&stream)
1313
, m_dtypes(get_column_dtypes(rb))

‎tests/test_chunk_memory_output_stream.cpp‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111

1212
namespace sparrow_ipc
1313
{
14-
TEST_SUITE("chuncked_memory_output_stream")
14+
TEST_SUITE("chunked_memory_output_stream")
1515
{
1616
TEST_CASE("basic construction")
1717
{
1818
SUBCASE("Construction with empty vector of vectors")
1919
{
2020
std::vector<std::vector<uint8_t>> chunks;
21-
chuncked_memory_output_stream stream(chunks);
21+
chunked_memory_output_stream stream(chunks);
2222

2323
CHECK(stream.is_open());
2424
CHECK_EQ(stream.size(), 0);
@@ -32,7 +32,7 @@ namespace sparrow_ipc
3232
{4, 5, 6, 7},
3333
{8, 9}
3434
};
35-
chuncked_memory_output_stream stream(chunks);
35+
chunked_memory_output_stream stream(chunks);
3636

3737
CHECK(stream.is_open());
3838
CHECK_EQ(stream.size(), 9);
@@ -45,7 +45,7 @@ namespace sparrow_ipc
4545
SUBCASE("Write single byte span")
4646
{
4747
std::vector<std::vector<uint8_t>> chunks;
48-
chuncked_memory_output_stream stream(chunks);
48+
chunked_memory_output_stream stream(chunks);
4949

5050
uint8_t data[] = {42};
5151
std::span<const uint8_t> span(data, 1);
@@ -62,7 +62,7 @@ namespace sparrow_ipc
6262
SUBCASE("Write multiple bytes span")
6363
{
6464
std::vector<std::vector<uint8_t>> chunks;
65-
chuncked_memory_output_stream stream(chunks);
65+
chunked_memory_output_stream stream(chunks);
6666

6767
uint8_t data[] = {1, 2, 3, 4, 5};
6868
std::span<const uint8_t> span(data, 5);
@@ -82,7 +82,7 @@ namespace sparrow_ipc
8282
SUBCASE("Write empty span")
8383
{
8484
std::vector<std::vector<uint8_t>> chunks;
85-
chuncked_memory_output_stream stream(chunks);
85+
chunked_memory_output_stream stream(chunks);
8686

8787
std::span<const uint8_t> empty_span;
8888

@@ -97,7 +97,7 @@ namespace sparrow_ipc
9797
SUBCASE("Multiple span writes create multiple chunks")
9898
{
9999
std::vector<std::vector<uint8_t>> chunks;
100-
chuncked_memory_output_stream stream(chunks);
100+
chunked_memory_output_stream stream(chunks);
101101

102102
uint8_t data1[] = {10, 20};
103103
uint8_t data2[] = {30, 40, 50};
@@ -129,7 +129,7 @@ namespace sparrow_ipc
129129
SUBCASE("Write moved vector")
130130
{
131131
std::vector<std::vector<uint8_t>> chunks;
132-
chuncked_memory_output_stream stream(chunks);
132+
chunked_memory_output_stream stream(chunks);
133133

134134
std::vector<uint8_t> buffer = {1, 2, 3, 4, 5};
135135
auto written = stream.write(std::move(buffer));
@@ -147,7 +147,7 @@ namespace sparrow_ipc
147147
SUBCASE("Write multiple moved vectors")
148148
{
149149
std::vector<std::vector<uint8_t>> chunks;
150-
chuncked_memory_output_stream stream(chunks);
150+
chunked_memory_output_stream stream(chunks);
151151

152152
std::vector<uint8_t> buffer1 = {10, 20, 30};
153153
std::vector<uint8_t> buffer2 = {40, 50};
@@ -168,7 +168,7 @@ namespace sparrow_ipc
168168
SUBCASE("Write empty moved vector")
169169
{
170170
std::vector<std::vector<uint8_t>> chunks;
171-
chuncked_memory_output_stream stream(chunks);
171+
chunked_memory_output_stream stream(chunks);
172172

173173
std::vector<uint8_t> empty_buffer;
174174
auto written = stream.write(std::move(empty_buffer));
@@ -185,7 +185,7 @@ namespace sparrow_ipc
185185
SUBCASE("Write value multiple times")
186186
{
187187
std::vector<std::vector<uint8_t>> chunks;
188-
chuncked_memory_output_stream stream(chunks);
188+
chunked_memory_output_stream stream(chunks);
189189

190190
auto written = stream.write(static_cast<uint8_t>(255), 5);
191191

@@ -202,7 +202,7 @@ namespace sparrow_ipc
202202
SUBCASE("Write value zero times")
203203
{
204204
std::vector<std::vector<uint8_t>> chunks;
205-
chuncked_memory_output_stream stream(chunks);
205+
chunked_memory_output_stream stream(chunks);
206206

207207
auto written = stream.write(static_cast<uint8_t>(42), 0);
208208

@@ -215,7 +215,7 @@ namespace sparrow_ipc
215215
SUBCASE("Multiple repeated value writes")
216216
{
217217
std::vector<std::vector<uint8_t>> chunks;
218-
chuncked_memory_output_stream stream(chunks);
218+
chunked_memory_output_stream stream(chunks);
219219

220220
stream.write(static_cast<uint8_t>(100), 3);
221221
stream.write(static_cast<uint8_t>(200), 2);
@@ -247,7 +247,7 @@ namespace sparrow_ipc
247247
TEST_CASE("mixed write operations")
248248
{
249249
std::vector<std::vector<uint8_t>> chunks;
250-
chuncked_memory_output_stream stream(chunks);
250+
chunked_memory_output_stream stream(chunks);
251251

252252
// Write span
253253
uint8_t data[] = {1, 2, 3};
@@ -282,7 +282,7 @@ namespace sparrow_ipc
282282
TEST_CASE("reserve functionality")
283283
{
284284
std::vector<std::vector<uint8_t>> chunks;
285-
chuncked_memory_output_stream stream(chunks);
285+
chunked_memory_output_stream stream(chunks);
286286

287287
// Reserve space
288288
stream.reserve(100);
@@ -306,7 +306,7 @@ namespace sparrow_ipc
306306
SUBCASE("Size with empty chunks")
307307
{
308308
std::vector<std::vector<uint8_t>> chunks;
309-
chuncked_memory_output_stream stream(chunks);
309+
chunked_memory_output_stream stream(chunks);
310310

311311
CHECK_EQ(stream.size(), 0);
312312
}
@@ -318,15 +318,15 @@ namespace sparrow_ipc
318318
{4, 5},
319319
{6, 7, 8, 9}
320320
};
321-
chuncked_memory_output_stream stream(chunks);
321+
chunked_memory_output_stream stream(chunks);
322322

323323
CHECK_EQ(stream.size(), 9);
324324
}
325325

326326
SUBCASE("Size updates after writes")
327327
{
328328
std::vector<std::vector<uint8_t>> chunks;
329-
chuncked_memory_output_stream stream(chunks);
329+
chunked_memory_output_stream stream(chunks);
330330

331331
CHECK_EQ(stream.size(), 0);
332332

@@ -345,7 +345,7 @@ namespace sparrow_ipc
345345
SUBCASE("Size with chunks of varying sizes")
346346
{
347347
std::vector<std::vector<uint8_t>> chunks;
348-
chuncked_memory_output_stream stream(chunks);
348+
chunked_memory_output_stream stream(chunks);
349349

350350
stream.write(static_cast<uint8_t>(1), 1);
351351
stream.write(static_cast<uint8_t>(2), 10);
@@ -360,7 +360,7 @@ namespace sparrow_ipc
360360
TEST_CASE("stream lifecycle")
361361
{
362362
std::vector<std::vector<uint8_t>> chunks;
363-
chuncked_memory_output_stream stream(chunks);
363+
chunked_memory_output_stream stream(chunks);
364364

365365
SUBCASE("Stream is always open")
366366
{
@@ -405,7 +405,7 @@ namespace sparrow_ipc
405405
TEST_CASE("large data handling")
406406
{
407407
std::vector<std::vector<uint8_t>> chunks;
408-
chuncked_memory_output_stream stream(chunks);
408+
chunked_memory_output_stream stream(chunks);
409409

410410
SUBCASE("Single large chunk")
411411
{
@@ -473,7 +473,7 @@ namespace sparrow_ipc
473473
SUBCASE("Maximum value writes")
474474
{
475475
std::vector<std::vector<uint8_t>> chunks;
476-
chuncked_memory_output_stream stream(chunks);
476+
chunked_memory_output_stream stream(chunks);
477477

478478
auto written = stream.write(std::numeric_limits<uint8_t>::max(), 255);
479479

@@ -489,7 +489,7 @@ namespace sparrow_ipc
489489
SUBCASE("Zero byte writes")
490490
{
491491
std::vector<std::vector<uint8_t>> chunks;
492-
chuncked_memory_output_stream stream(chunks);
492+
chunked_memory_output_stream stream(chunks);
493493

494494
auto written = stream.write(static_cast<uint8_t>(0), 100);
495495

@@ -505,7 +505,7 @@ namespace sparrow_ipc
505505
SUBCASE("Interleaved empty and non-empty writes")
506506
{
507507
std::vector<std::vector<uint8_t>> chunks;
508-
chuncked_memory_output_stream stream(chunks);
508+
chunked_memory_output_stream stream(chunks);
509509

510510
stream.write(static_cast<uint8_t>(1), 5);
511511
stream.write(static_cast<uint8_t>(2), 0);
@@ -530,7 +530,7 @@ namespace sparrow_ipc
530530
SUBCASE("Stream modifies original chunks vector")
531531
{
532532
std::vector<std::vector<uint8_t>> chunks;
533-
chuncked_memory_output_stream stream(chunks);
533+
chunked_memory_output_stream stream(chunks);
534534

535535
uint8_t data[] = {1, 2, 3};
536536
stream.write(std::span<const uint8_t>(data, 3));
@@ -548,13 +548,13 @@ namespace sparrow_ipc
548548
std::vector<std::vector<uint8_t>> chunks;
549549

550550
{
551-
chuncked_memory_output_stream stream1(chunks);
551+
chunked_memory_output_stream stream1(chunks);
552552
uint8_t data1[] = {10, 20};
553553
stream1.write(std::span<const uint8_t>(data1, 2));
554554
}
555555

556556
{
557-
chuncked_memory_output_stream stream2(chunks);
557+
chunked_memory_output_stream stream2(chunks);
558558
uint8_t data2[] = {30, 40};
559559
stream2.write(std::span<const uint8_t>(data2, 2));
560560
}

0 commit comments

Comments
 (0)