Skip to content

Commit c6f0202

Browse files
committed
wip
1 parent 190af27 commit c6f0202

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

tests/test_primitive_array_with_files.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const std::filesystem::path tests_resources_files_path = TESTS_RESOURCES_FILES_P
1919

2020
const std::vector<std::filesystem::path> files_paths_to_test = {
2121
tests_resources_files_path / "generated_primitive",
22-
tests_resources_files_path / "generated_primitive_large_offsets",
22+
// tests_resources_files_path / "generated_primitive_large_offsets",
2323
tests_resources_files_path / "generated_primitive_zerolength",
2424
tests_resources_files_path / "generated_primitive_no_batches"
2525
};
@@ -92,12 +92,16 @@ TEST_SUITE("Integration tests")
9292
{
9393
for(size_t y = 0; y < record_batches_from_stream[i].nb_columns(); y++)
9494
{
95-
for(size_t z = 0 ; z < record_batches_from_stream[i].get_column(y).size(); z++)
95+
const auto& column_stream = record_batches_from_stream[i].get_column(y);
96+
const auto& column_json = record_batches_from_json[i].get_column(y);
97+
REQUIRE_EQ(column_stream.size(), column_json.size());
98+
for(size_t z = 0 ; z < column_json.size(); z++)
9699
{
97-
const auto col_name = record_batches_from_stream[i].get_column(y).name().value_or("NA");
100+
const auto col_name = column_stream.name().value_or("NA");
98101
INFO("Comparing batch " << i << ", column " << y << " named :"<< col_name <<" , row " << z);
99-
REQUIRE_EQ(record_batches_from_stream[i].get_column(y).size(), record_batches_from_json[i].get_column(y).size());
100-
CHECK_EQ(record_batches_from_stream[i].get_column(y).at(z), record_batches_from_json[i].get_column(y).at(z));
102+
const auto& column_stream_value = column_stream[z];
103+
const auto& column_json_value = column_json[z];
104+
CHECK_EQ(column_stream_value, column_json_value);
101105
}
102106
}
103107
}

0 commit comments

Comments
 (0)