Skip to content

Commit cd8f07b

Browse files
committed
Remove commented code
1 parent 5661b68 commit cd8f07b

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

include/serialize_null_array.hpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,7 @@ namespace sparrow_ipc
5757
{
5858
sparrow::key_value_view metadata_view = *(arr.metadata());
5959
std::vector<flatbuffers::Offset<org::apache::arrow::flatbuf::KeyValue>> kv_offsets;
60-
// kv_offsets.reserve(metadata_view.size());
61-
// for (const auto& pair : metadata_view)
62-
// {
63-
// auto key_offset = schema_builder.CreateString(std::string(pair.first));
64-
// auto value_offset = schema_builder.CreateString(std::string(pair.second));
65-
// kv_offsets.push_back(
66-
// org::apache::arrow::flatbuf::CreateKeyValue(schema_builder, key_offset, value_offset));
67-
// }
60+
kv_offsets.reserve(metadata_view.size());
6861
auto mv_it = metadata_view.cbegin();
6962
for (auto i = 0; i < metadata_view.size(); ++i, ++mv_it)
7063
{

include/serialize_primitive_array.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ namespace sparrow_ipc
6868
{
6969
sparrow::key_value_view metadata_view = *(arr.metadata());
7070
std::vector<flatbuffers::Offset<org::apache::arrow::flatbuf::KeyValue>> kv_offsets;
71-
71+
kv_offsets.reserve(metadata_view.size());
7272
auto mv_it = metadata_view.cbegin();
7373
for (auto i = 0; i < metadata_view.size(); ++i, ++mv_it)
7474
{

0 commit comments

Comments
 (0)