Skip to content

Commit cfbcb4b

Browse files
committed
Rename ENABLE_COVERAGE
1 parent 6ff0634 commit cfbcb4b

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
if: matrix.build_type == 'Debug'
6666
run: |
6767
choco install opencppcoverage
68-
echo "TEST_COVERAGE_ACTIVATION=' -DENABLE_COVERAGE=ON'" >> $GITHUB_ENV
68+
echo "TEST_COVERAGE_ACTIVATION=' -DSPARROW_IPC_ENABLE_COVERAGE=ON'" >> $GITHUB_ENV
6969
7070
- name: Configure using cmake
7171
run: |

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ MESSAGE(STATUS "🔧 Build tests: ${SPARROW_IPC_BUILD_TESTS}")
4747
OPTION(BUILD_DOCS "Build sparrow-ipc documentation" OFF)
4848
MESSAGE(STATUS "🔧 Build docs: ${BUILD_DOCS}")
4949

50-
OPTION(ENABLE_COVERAGE "Enable test coverage" OFF)
51-
MESSAGE(STATUS "🔧 Enable coverage: ${ENABLE_COVERAGE}")
50+
OPTION(SPARROW_IPC_ENABLE_COVERAGE "Enable test coverage" OFF)
51+
MESSAGE(STATUS "🔧 Enable coverage: ${SPARROW_IPC_ENABLE_COVERAGE}")
5252

5353
set(SPARROW_IPC_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include)
5454
set(SPARROW_IPC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src)
@@ -159,9 +159,9 @@ target_link_libraries(sparrow-ipc
159159

160160
add_dependencies(sparrow-ipc generate_flatbuffers_headers)
161161

162-
if(ENABLE_COVERAGE)
162+
if(SPARROW_IPC_ENABLE_COVERAGE)
163163
include(code_coverage)
164-
enable_coverage(sparrow-ipc)
164+
#enable_coverage(sparrow-ipc)
165165
endif()
166166
# Tests
167167
# =====

cmake/code_coverage.cmake

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "
3838
endif()
3939

4040
#TODO this may not be useful if coverage only on Windows ci?
41-
function(enable_coverage target)
42-
set(CLANG_COVERAGE_FLAGS --coverage -fprofile-instr-generate -fcoverage-mapping -fno-inline -fno-elide-constructors)
43-
set(GCC_COVERAGE_FLAGS --coverage -fno-inline -fno-inline-small-functions -fno-default-inline)
44-
45-
target_compile_options(${target} PRIVATE
46-
$<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
47-
$<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
48-
target_link_options(${target} PRIVATE
49-
$<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
50-
$<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
51-
endfunction(enable_coverage target)
41+
# function(enable_coverage target)
42+
# set(CLANG_COVERAGE_FLAGS --coverage -fprofile-instr-generate -fcoverage-mapping -fno-inline -fno-elide-constructors)
43+
# set(GCC_COVERAGE_FLAGS --coverage -fno-inline -fno-inline-small-functions -fno-default-inline)
44+
#
45+
# target_compile_options(${target} PRIVATE
46+
# $<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
47+
# $<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
48+
# target_link_options(${target} PRIVATE
49+
# $<$<CXX_COMPILER_ID:Clang>:${CLANG_COVERAGE_FLAGS}>
50+
# $<$<CXX_COMPILER_ID:GNU>:${GCC_COVERAGE_FLAGS}>)
51+
# endfunction(enable_coverage target)

tests/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ set(
1414

1515
add_executable(${test_target} ${SPARROW_IPC_TESTS_SRC})
1616

17-
if(ENABLE_COVERAGE)
18-
enable_coverage(${test_target})
19-
endif()
17+
# if(ENABLE_COVERAGE)
18+
# enable_coverage(${test_target})
19+
# endif()
2020

2121
target_link_libraries(${test_target}
2222
PRIVATE

0 commit comments

Comments
 (0)