Skip to content

Commit e6da7d0

Browse files
committed
Move includes around
1 parent d24c266 commit e6da7d0

File tree

4 files changed

+5
-32
lines changed

4 files changed

+5
-32
lines changed

include/serialize.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
#pragma once
22

3+
#include <cstdint>
34
#include <optional>
5+
#include <string>
46
#include <vector>
57

68
#include "sparrow.hpp"
79

10+
#include "Message_generated.h"
11+
#include "Schema_generated.h"
12+
813
#include "config/config.hpp"
914

1015
namespace sparrow_ipc

include/serialize_null_array.hpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,10 @@
11
#pragma once
22

3-
// TODO check needs of all these below
4-
#include <cstdint>
5-
#include <cstring>
6-
#include <optional>
7-
#include <stdexcept>
8-
#include <string>
9-
#include <vector>
10-
11-
#include "sparrow.hpp"
12-
13-
// TODO check needs of these two
14-
#include "Message_generated.h"
15-
#include "Schema_generated.h"
16-
173
#include "serialize.hpp"
18-
#include "utils.hpp"
194

205
namespace sparrow_ipc
216
{
227
// TODO move to cpp if not templated
23-
// TODO add comments and review
248

259
// This function serializes a sparrow::null_array into a byte vector compliant
2610
// with the Apache Arrow IPC Streaming Format. It mirrors the structure of

include/serialize_primitive_array.hpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,6 @@
11
#pragma once
22

3-
#include <cstdint>
43
#include <cstring>
5-
#include <optional>
6-
#include <stdexcept>
7-
#include <string>
8-
#include <vector>
9-
10-
#include "sparrow.hpp"
11-
12-
#include "Message_generated.h"
13-
#include "Schema_generated.h"
144

155
#include "serialize.hpp"
166
#include "utils.hpp"

src/serialize.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
// TODO check need of all these includes
2-
#include <cstdint>
31
#include <cstring>
42
#include <stdexcept>
5-
#include <string>
6-
7-
#include "Message_generated.h"
8-
#include "Schema_generated.h"
93

104
#include "serialize.hpp"
115
#include "utils.hpp"

0 commit comments

Comments
 (0)