Skip to content

Commit fe5fe00

Browse files
Hind-MAlex-PLACET
authored andcommitted
Change build tests option name (conflict)
1 parent 361c3db commit fe5fe00

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.github/workflows/linux.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
-DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \
3636
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
3737
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \
38-
-DBUILD_TESTS=ON
38+
-DSPARROW_IPC_BUILD_TESTS=ON
3939
cmake --build build/ --parallel
4040
- name: Run tests
4141
run: |
@@ -65,7 +65,7 @@ jobs:
6565
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
6666
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \
6767
-DFETCH_DEPENDENCIES_WITH_CMAKE=MISSING \
68-
-DBUILD_TESTS=ON
68+
-DSPARROW_IPC_BUILD_TESTS=ON
6969
cmake --build build/ --parallel
7070
- name: Run tests
7171
run: |

.github/workflows/osx.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
-DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \
3636
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
3737
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \
38-
-DBUILD_TESTS=ON
38+
-DSPARROW_IPC_BUILD_TESTS=ON
3939
cmake --build build/ --parallel
4040
- name: Run tests
4141
run: |
@@ -65,7 +65,7 @@ jobs:
6565
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
6666
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \
6767
-DFETCH_DEPENDENCIES_WITH_CMAKE=MISSING \
68-
-DBUILD_TESTS=ON
68+
-DSPARROW_IPC_BUILD_TESTS=ON
6969
cmake --build build/ --parallel
7070
- name: Run tests
7171
run: |

.github/workflows/windows.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
-DCMAKE_PREFIX_PATH=%CONDA_PREFIX% ^
3939
-DCMAKE_CXX_STANDARD=20 ^
4040
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} ^
41-
-DBUILD_TESTS=ON
41+
-DSPARROW_IPC_BUILD_TESTS=ON
4242
if %errorlevel% neq 0 exit /b %errorlevel%
4343
cmake --build build/ --parallel
4444
if %errorlevel% neq 0 exit /b %errorlevel%
@@ -75,7 +75,7 @@ jobs:
7575
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} ^
7676
-DFETCH_DEPENDENCIES_WITH_CMAKE=MISSING ^
7777
-DCMAKE_VERBOSE_MAKEFILE=ON ^^
78-
-DBUILD_TESTS=ON
78+
-DSPARROW_IPC_BUILD_TESTS=ON
7979
if %errorlevel% neq 0 exit /b %errorlevel%
8080
cmake --build build/ --parallel
8181
if %errorlevel% neq 0 exit /b %errorlevel%

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ else()
4141
list(APPEND SPARROW_IPC_COMPILE_DEFINITIONS SPARROW_IPC_STATIC_LIB)
4242
endif()
4343

44-
OPTION(BUILD_TESTS "Build sparrow-ipc test suite" OFF)
45-
MESSAGE(STATUS "🔧 Build tests: ${BUILD_TESTS}")
44+
OPTION(SPARROW_IPC_BUILD_TESTS "Build sparrow-ipc test suite" OFF)
45+
MESSAGE(STATUS "🔧 Build tests: ${SPARROW_IPC_BUILD_TESTS}")
4646

4747
set(SPARROW_IPC_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include)
4848
set(SPARROW_IPC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/src)
@@ -147,7 +147,7 @@ endif()
147147

148148
add_dependencies(sparrow-ipc generate_flatbuffers_headers)
149149

150-
if(BUILD_TESTS)
150+
if(SPARROW_IPC_BUILD_TESTS)
151151
message(STATUS "🧪 Create tests targets")
152152
enable_testing()
153153
add_subdirectory(tests)

cmake/external_dependencies.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ if(FETCH_DEPENDENCIES_WITH_CMAKE STREQUAL "ON" OR FETCH_DEPENDENCIES_WITH_CMAKE
3535
endif()
3636
endif()
3737

38-
if(BUILD_TESTS)
38+
if(SPARROW_IPC_BUILD_TESTS)
3939
if(NOT FETCH_DEPENDENCIES_WITH_CMAKE STREQUAL "ON")
4040
find_package(doctest CONFIG ${FIND_PACKAGE_OPTIONS})
4141
endif()

0 commit comments

Comments
 (0)