From bed35b3901070c49f7e77ed6f1390cc85e79d8cd Mon Sep 17 00:00:00 2001 From: Hind Montassif Date: Tue, 28 Oct 2025 17:09:45 +0100 Subject: [PATCH 1/5] Update sparrow version for conan --- conanfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conanfile.py b/conanfile.py index e2f251a..2687519 100644 --- a/conanfile.py +++ b/conanfile.py @@ -43,7 +43,7 @@ def configure(self): self.options.rm_safe("fPIC") def requirements(self): - self.requires("sparrow/1.0.0") + self.requires("sparrow/1.3.0") self.requires(f"flatbuffers/{self._flatbuffers_version}") self.requires("lz4/1.9.4") #self.requires("zstd/1.5.5") From 5a9a9ffa7fa3c42c5948253c76c2846e0211c68c Mon Sep 17 00:00:00 2001 From: Hind Montassif Date: Thu, 30 Oct 2025 11:30:39 +0100 Subject: [PATCH 2/5] Set sparrow with_json_reader option to True --- .github/workflows/conan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/conan.yaml b/.github/workflows/conan.yaml index 12082d8..5c02e37 100644 --- a/.github/workflows/conan.yaml +++ b/.github/workflows/conan.yaml @@ -25,7 +25,7 @@ jobs: - name: Install conan dependencies run: | conan profile detect --force - conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True + conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o sparrow:with_json_reader=True - name: CMake configuration run: | From b49e4d337be1633ba13473e9c8e4e40ca2cf9b8c Mon Sep 17 00:00:00 2001 From: Hind Montassif Date: Thu, 30 Oct 2025 15:08:06 +0100 Subject: [PATCH 3/5] Use export_json_reader --- .github/workflows/conan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/conan.yaml b/.github/workflows/conan.yaml index 5c02e37..b1adca4 100644 --- a/.github/workflows/conan.yaml +++ b/.github/workflows/conan.yaml @@ -25,7 +25,7 @@ jobs: - name: Install conan dependencies run: | conan profile detect --force - conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o sparrow:with_json_reader=True + conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o sparrow:export_json_reader=True - name: CMake configuration run: | From ba1e4714ff36cc23cd865f7ecc03ac29cef43288 Mon Sep 17 00:00:00 2001 From: Hind Montassif Date: Thu, 30 Oct 2025 15:26:54 +0100 Subject: [PATCH 4/5] Use new syntax --- .github/workflows/conan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/conan.yaml b/.github/workflows/conan.yaml index b1adca4..553c85e 100644 --- a/.github/workflows/conan.yaml +++ b/.github/workflows/conan.yaml @@ -25,7 +25,7 @@ jobs: - name: Install conan dependencies run: | conan profile detect --force - conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o sparrow:export_json_reader=True + conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o "sparrow/*:export_json_reader=True" - name: CMake configuration run: | From 588213dd6adef15c43eb13dd7fd3b85f1f78cf94 Mon Sep 17 00:00:00 2001 From: Hind Montassif Date: Thu, 30 Oct 2025 15:46:51 +0100 Subject: [PATCH 5/5] Fix syntax --- .github/workflows/conan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/conan.yaml b/.github/workflows/conan.yaml index 553c85e..5fcde6e 100644 --- a/.github/workflows/conan.yaml +++ b/.github/workflows/conan.yaml @@ -25,7 +25,7 @@ jobs: - name: Install conan dependencies run: | conan profile detect --force - conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True -o "sparrow/*:export_json_reader=True" + conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o "&:build_tests=True" -o "sparrow/*:export_json_reader=True" - name: CMake configuration run: |