wip

Author: Alex-PLACET

src/pycapsule.cpp

@@ -131,7 +131,18 @@ namespace sparrow::pycapsule
         ArrowArray* array_ptr = new ArrowArray(std::move(arrow_array));
 
         PyObject* schema_capsule = PyCapsule_New(schema_ptr, arrow_schema_str.data(), release_arrow_schema_pycapsule);
+        if (!schema_capsule) {
+            delete schema_ptr;
+            delete array_ptr;
+            return {nullptr, nullptr};
+        }
         PyObject* array_capsule = PyCapsule_New(array_ptr, arrow_array_str.data(), release_arrow_array_pycapsule);
+        if (!array_capsule) {
+            delete schema_ptr;
+            delete array_ptr;
+            Py_DECREF(schema_capsule);
+            return {nullptr, nullptr};
+        }
 
         return {schema_capsule, array_capsule};
     }

test/test_pycapsule.cpp

@@ -405,7 +405,7 @@ namespace sparrow::pycapsule
             SUBCASE("destructor_handles_already_released_schema")
             {
                 // Create a schema with null release callback
-                ArrowSchema* schema = new ArrowSchema();
+                ArrowSchema* schema = new ArrowSchema{};
                 schema->release = nullptr;
 
                 PyObject* capsule = PyCapsule_New(schema, "arrow_schema", release_arrow_schema_pycapsule);
@@ -422,7 +422,7 @@ namespace sparrow::pycapsule
             SUBCASE("destructor_handles_already_released_array")
             {
                 // Create an array with null release callback
-                ArrowArray* array = new ArrowArray();
+                ArrowArray* array = new ArrowArray{};
                 array->release = nullptr;
 
                 PyObject* capsule = PyCapsule_New(array, "arrow_array", release_arrow_array_pycapsule);