Review

Author: borchero

dataframely/_deprecation.py

@@ -19,8 +19,7 @@ def skip_if(env: str) -> Callable:
     def decorator(fun: Callable) -> Callable:
         @wraps(fun)
         def wrapper() -> None:
-            should_skip = os.getenv(env, "").lower() in TRUTHY_VALUES
-            if should_skip:
+            if os.getenv(env, "").lower() in TRUTHY_VALUES:
                 return
             fun()
 

pyproject.toml

@@ -22,8 +22,8 @@ requires-python = ">=3.11"
 version = "0.0.0"
 
 [project.urls]
-Repository = "https://github.com/quantco/dataframely"
 Documentation = "https://dataframely.readthedocs.io/"
+Repository = "https://github.com/quantco/dataframely"
 
 [tool.maturin]
 module-name = "dataframely._extre"
@@ -82,7 +82,8 @@ module = ["pyarrow.*"]
 [tool.pytest.ini_options]
 addopts = "--import-mode=importlib"
 filterwarnings = [
-  "ignore:datetime.datetime.utcfromtimestamp\\(\\) is deprecated.*:DeprecationWarning",
+  # Almost all tests are oblivious to the value of `nullable`. Let's ignore the warning as long as it exists.
+  "ignore:The 'nullable' argument was not explicitly set:FutureWarning",
 ]
 testpaths = ["tests"]