scikit-learn compliant zero-weights error (#965)

* sklearn compliant error message on zero weights

* Update test

* Remove retired runner

Author: stanmart

.github/workflows/build_wheels.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-22.04, ubuntu-22.04-arm, windows-2022, macos-13, macos-14]
+        os: [ubuntu-22.04, ubuntu-22.04-arm, windows-2022, macos-15, macos-15-intel]
 
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

src/glum/_validation.py

@@ -212,6 +212,6 @@ def check_weights(
     if np.any(sample_weight < 0):  # type: ignore
         raise ValueError("Sample weights must be non-negative.")
     if np.sum(sample_weight) == 0:  # type: ignore
-        raise ValueError("Sample weights must have at least one positive element.")
+        raise ValueError("Sample weights must not all be zero.")
 
     return sample_weight  # type: ignore

tests/glm/test_glm_base.py

@@ -87,7 +87,7 @@ def test_sample_weights_validation(estimator, kwargs):
     sample_weight = [0, 0]
     X = [[0], [1]]
     y = [1, 2]
-    with pytest.raises(ValueError, match="must have at least one positive element"):
+    with pytest.raises(ValueError, match="must not all be zero"):
         glm.fit(X, y, sample_weight)
 
     # 5. 1d but with a negative value